Differential D13202

textproc/fcitx-qt5: Update to 1.2.1
ClosedPublic
Actions

Authored by yuri on Nov 22 2017, 11:31 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Mar 23, 3:49 AM

	Unknown Object (File)
	Mar 10 2024, 4:56 AM

	Unknown Object (File)
	Mar 10 2024, 4:56 AM

	Unknown Object (File)
	Mar 10 2024, 4:56 AM

	Unknown Object (File)
	Mar 10 2024, 4:56 AM

	Unknown Object (File)
	Mar 10 2024, 4:56 AM

	Unknown Object (File)
	Mar 10 2024, 4:56 AM

	Unknown Object (File)
	Mar 8 2024, 8:54 PM

View All 56 Files

Subscribers

Details

Reviewers

tcberner
adamw

Commits

rP454741: textproc/fcitx-qt5: Update to 1.2.1

Summary

Simple update.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

yuri created this revision.Nov 22 2017, 11:31 PM

Herald added a subscriber: mat. · View Herald TranscriptNov 22 2017, 11:31 PM

Harbormaster completed remote builds in B12956: Diff 35623.Nov 22 2017, 11:31 PM

.

Harbormaster completed remote builds in B12957: Diff 35624.Nov 22 2017, 11:52 PM

tcberner added inline comments.Nov 23 2017, 5:39 AM

textproc/fcitx-qt5/Makefile
20 ↗	(On Diff #35624)	^ qmake_build should suffice

.

yuri marked an inline comment as done.Nov 23 2017, 5:51 AM

yuri added inline comments.

textproc/fcitx-qt5/Makefile
20 ↗	(On Diff #35624)	Indeed. -)

yuri marked 2 inline comments as done.Nov 23 2017, 5:51 AM

tcberner added inline comments.Nov 23 2017, 5:58 AM

textproc/fcitx-qt5/Makefile
16 ↗	(On Diff #35631)	^ drop gettext
23 ↗	(On Diff #35631)	^ NLS_USES=gettext
23 ↗	(On Diff #35631)	^ not here, but near NLS_CMAKE_BOOL ^^

.

Harbormaster completed remote builds in B12963: Diff 35634.Nov 23 2017, 6:12 AM

yuri added inline comments.Nov 23 2017, 6:12 AM

textproc/fcitx-qt5/Makefile
16 ↗	(On Diff #35631)	cmake's NLS doesn't cleanly disable gettext. I added it with a patch, but it was incomplete. I rolled it back, and asked them to implement it: https://github.com/fcitx/fcitx-qt5/issues/29

yuri marked an inline comment as done.Nov 23 2017, 6:12 AM

Looks ok.

This revision is now accepted and ready to land.Nov 23 2017, 6:31 AM

Closed by commit rP454741: textproc/fcitx-qt5: Update to 1.2.1 (authored by yuri). · Explain WhyNov 23 2017, 6:33 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

textproc/

fcitx-qt5/

6 lines

6 lines

15 lines

Diff 35638

head/textproc/fcitx-qt5/Makefile

Loading...

head/textproc/fcitx-qt5/distinfo

Loading...

head/textproc/fcitx-qt5/pkg-plist

Loading...