Page MenuHomeFreeBSD
Differential D13121

New Port: databases/lua-resty-redis
ClosedPublic
Actions

Authored by joneum on Nov 16 2017, 4:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 23, 2:39 PM
Unknown Object (File)
Tue, Apr 23, 2:39 PM
Unknown Object (File)
Tue, Apr 23, 2:39 PM
Unknown Object (File)
Tue, Apr 23, 2:39 PM
Unknown Object (File)
Tue, Apr 23, 2:39 PM
Unknown Object (File)
Tue, Apr 23, 2:39 PM
Unknown Object (File)
Tue, Apr 23, 2:26 PM
Unknown Object (File)
Mar 22 2024, 1:18 PM
View All 54 Files
Subscribers
mat

Details

Reviewers
tz
rene
tcberner
Commits
rP454333: New Port: lua-resty-redis - for accessing redis from nginx lua
Summary

New Port: lua-resty-redis - for accessing redis from nginx lua

This Lua library is a Redis client driver for the ngx_lua nginx module:

http://wiki.nginx.org/HttpLuaModule

This Lua library takes advantage of ngx_lua's cosocket API, which ensures 100%
nonblocking behavior.

WWW: https://github.com/openresty/lua-resty-redis

PR: 191531
Submitted by: arcade@b1t.name

Approved by: xxx (mentor)
#Differential Revision: https://reviews.freebsd.org/Dxxxxx

Test Plan

:~/dev/ports/databases/lua-resty-redis % portlint -AC
looks fine.

poudriere testport:

10.3-amd64
10.3-i386
10.4-amd64
10.4-i386
11.1-amd64
11.1-i386
12.0-CURRENT r325045 amd64
12.0-CURRENT r325045 i386

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 12784
Build 13052: arc lint + arc unit

Event Timeline

joneum created this revision.Nov 16 2017, 4:32 PM
Herald added a subscriber: mat. · View Herald TranscriptNov 16 2017, 4:32 PM
Harbormaster completed remote builds in B12784: Diff 35324.Nov 16 2017, 4:32 PM
tz added a comment.Nov 16 2017, 4:34 PM

The log message should contain the full pkg-descr text!

joneum edited the summary of this revision. (Show Details)Nov 16 2017, 4:55 PM
tcberner added inline comments.Nov 16 2017, 6:05 PM
databases/lua-resty-redis/Makefile
4

^ this is a new port, use DISTVERSION and remember to switch the ordering with DISTVERSIONPREFIX.

databases/lua-resty-redis/pkg-plist
2

^ @dir should not be necessary -- as it is neither empty directory nor outside of prefix.

joneum marked 2 inline comments as done.Nov 16 2017, 6:55 PM
joneum updated this revision to Diff 35337.Nov 16 2017, 6:58 PM

change to DISTVERSION, delete @dir

Harbormaster completed remote builds in B12791: Diff 35337.Nov 16 2017, 6:59 PM
tcberner added inline comments.Nov 16 2017, 7:00 PM
databases/lua-resty-redis/pkg-plist
2

I meant, you should drop that whole line =)

joneum updated this revision to Diff 35338.Nov 16 2017, 7:01 PM

update pkg-plist

Harbormaster completed remote builds in B12792: Diff 35338.Nov 16 2017, 7:01 PM
tcberner accepted this revision.Nov 16 2017, 7:07 PM

This possibly could use NO_ARCH -- though I'm not sure :)

So better to leave it as is .

This revision is now accepted and ready to land.Nov 16 2017, 7:07 PM
joneum updated this revision to Diff 35339.Nov 16 2017, 7:09 PM

Add "NO_ARCH" to the Makefile.
There is this info into the log: pkg-static: DEVELOPER_MODE: Notice: arch "FreeBSD:11:i386" -- no architecture specific files found:

This revision now requires review to proceed.Nov 16 2017, 7:09 PM
Harbormaster completed remote builds in B12793: Diff 35339.Nov 16 2017, 7:09 PM
Closed by commit rP454333: New Port: lua-resty-redis - for accessing redis from nginx lua (authored by joneum). · Explain WhyNov 16 2017, 8:02 PM
This revision was automatically updated to reflect the committed changes.
mat added inline comments.Nov 24 2017, 5:32 PM
head/databases/lua-resty-redis/pkg-plist
1 ↗(On Diff #35342)

This could probably be in a PLIST_FILE variable in the Makefile.

Revision Contents
Changeset List

PathSize
databases/
1 line
17 lines
2 lines
11 lines
8 lines
2 lines

Diff 35324

View Options

databases/Makefile

Loading...
View Options

databases/lua-resty-redis/

Loading...
View Options

databases/lua-resty-redis/Makefile

Loading...
View Options

databases/lua-resty-redis/distinfo

Loading...
View Options

databases/lua-resty-redis/files/

Loading...
View Options

databases/lua-resty-redis/files/patch-Makefile

Loading...
View Options

databases/lua-resty-redis/pkg-descr

Loading...
View Options

databases/lua-resty-redis/pkg-plist

Loading...