Page MenuHomeFreeBSD
Differential D13080

New port: science/erd: AcesIII electron repulsion integrals
ClosedPublic
Actions

Authored by yuri on Nov 14 2017, 9:05 AM.
Tags
None
Referenced Files
F164286690: D13080.id35223.diff
Thu, Jul 30, 10:04 AM
Unknown Object (File)
Sun, Jul 26, 1:33 AM
Unknown Object (File)
Sat, Jul 25, 8:22 AM
Unknown Object (File)
Fri, Jul 24, 9:55 PM
Unknown Object (File)
Fri, Jul 24, 2:40 AM
Unknown Object (File)
Wed, Jul 22, 8:19 PM
Unknown Object (File)
Tue, Jul 21, 5:27 PM
Unknown Object (File)
Tue, Jul 21, 9:43 AM
View All Files
Subscribers
mat

Details

Reviewers
tcberner
adamw
Commits
rP454190: New port: science/erd: AcesIII electron repulsion integrals
Summary

To support psi4 quantunm chemistry package

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 12745
Build 13013: arc lint + arc unit

Event Timeline

yuri created this revision.Nov 14 2017, 9:05 AM
Herald added a subscriber: mat. · View Herald TranscriptNov 14 2017, 9:05 AM
Harbormaster completed remote builds in B12734: Diff 35223.Nov 14 2017, 9:05 AM
tcberner added inline comments.Nov 14 2017, 5:49 PM
science/erd/Makefile
20

^ it looks weird to set empty with +=
[though I also like the symmetry :D ]

Probably you should prefer:

CMAKE_ARGS= -DBUILD...\
            -DENABLE...
yuri marked an inline comment as done.Nov 14 2017, 6:02 PM
yuri added inline comments.
science/erd/Makefile
20

Besides symmetry, individual lines are easier to remove/comment out. And the price is only a few extra characters.

Do you still think it should be changed?

tcberner added inline comments.Nov 14 2017, 6:15 PM
science/erd/Makefile
20

Even though it pains me, yes :-)

yuri updated this revision to Diff 35247.Nov 14 2017, 6:18 PM
yuri marked an inline comment as done.

Changed CMAKE_ARGS. We can live with the pain.

Harbormaster completed remote builds in B12745: Diff 35247.Nov 14 2017, 6:18 PM
yuri marked 2 inline comments as done.Nov 14 2017, 6:19 PM
tcberner accepted this revision.Nov 14 2017, 6:24 PM
This revision is now accepted and ready to land.Nov 14 2017, 6:24 PM
Closed by commit rP454190: New port: science/erd: AcesIII electron repulsion integrals (authored by yuri). · Explain WhyNov 14 2017, 6:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
science/
1 line
22 lines
3 lines
8 lines
6 lines

Diff 35247

View Options

science/Makefile

Loading...
View Options

science/erd/

Loading...
View Options

science/erd/Makefile

Loading...
View Options

science/erd/distinfo

Loading...
View Options

science/erd/pkg-descr

Loading...
View Options

science/erd/pkg-plist

Loading...