Differential D13080

New port: science/erd: AcesIII electron repulsion integrals
ClosedPublic
Actions

Authored by yuri on Nov 14 2017, 9:05 AM.

Tags

None

Referenced Files

	F133256191: D13080.id35247.diff
	Fri, Oct 24, 9:35 AM

	Unknown Object (File)
	Mon, Oct 20, 8:34 AM

	Unknown Object (File)
	Sun, Oct 19, 5:28 PM

	Unknown Object (File)
	Sun, Oct 19, 5:28 PM

	Unknown Object (File)
	Sun, Oct 19, 5:28 PM

	Unknown Object (File)
	Sun, Oct 19, 5:28 PM

	Unknown Object (File)
	Fri, Oct 17, 3:39 AM

	Unknown Object (File)
	Thu, Oct 9, 7:16 PM

Subscribers

Details

Reviewers

tcberner
adamw

Commits

rP454190: New port: science/erd: AcesIII electron repulsion integrals

Summary

To support psi4 quantunm chemistry package

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

yuri created this revision.Nov 14 2017, 9:05 AM

Herald added a subscriber: mat. · View Herald TranscriptNov 14 2017, 9:05 AM

Harbormaster completed remote builds in B12734: Diff 35223.Nov 14 2017, 9:05 AM

tcberner added inline comments.Nov 14 2017, 5:49 PM

science/erd/Makefile
19 ↗	(On Diff #35223)	^ it looks weird to set empty with += [though I also like the symmetry :D ] Probably you should prefer: CMAKE_ARGS= -DBUILD...\ -DENABLE...

yuri marked an inline comment as done.Nov 14 2017, 6:02 PM

yuri added inline comments.

science/erd/Makefile
19 ↗	(On Diff #35223)	Besides symmetry, individual lines are easier to remove/comment out. And the price is only a few extra characters. Do you still think it should be changed?

tcberner added inline comments.Nov 14 2017, 6:15 PM

science/erd/Makefile
19 ↗	(On Diff #35223)	Even though it pains me, yes :-)

Changed CMAKE_ARGS. We can live with the pain.

Harbormaster completed remote builds in B12745: Diff 35247.Nov 14 2017, 6:18 PM

yuri marked 2 inline comments as done.Nov 14 2017, 6:19 PM

tcberner accepted this revision.Nov 14 2017, 6:24 PM

This revision is now accepted and ready to land.Nov 14 2017, 6:24 PM

Closed by commit rP454190: New port: science/erd: AcesIII electron repulsion integrals (authored by yuri). · Explain WhyNov 14 2017, 6:44 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

science/

1 line

erd/

22 lines

3 lines

8 lines

6 lines

Diff 35249

head/science/Makefile

Loading...

head/science/erd/Makefile

Loading...

head/science/erd/distinfo

Loading...

head/science/erd/pkg-descr

Loading...

head/science/erd/pkg-plist

Loading...