Page MenuHomeFreeBSD
Differential D12981

Document MACHINE, MACHINE_ARCH, TARGET and TARGET_ARCH historical use and general philosphy.
ClosedPublic
Actions

Authored by imp on Nov 7 2017, 6:34 PM.
Tags
None
Referenced Files
F82314180: D12981.diff
Sat, Apr 27, 2:09 PM
Unknown Object (File)
Mar 7 2024, 11:31 PM
Unknown Object (File)
Dec 20 2023, 4:54 AM
Unknown Object (File)
Nov 23 2023, 6:09 AM
Unknown Object (File)
Nov 11 2023, 3:03 PM
Unknown Object (File)
Oct 11 2023, 5:20 AM
Unknown Object (File)
Oct 10 2023, 2:00 PM
Unknown Object (File)
Aug 12 2023, 9:15 PM
View All 11 Files
Subscribers
bcr
bdrewery

Details

Reviewers
emaste
bdrewery
Commits
rS325749: Document MACHINE, MACHINE_ARCH, CPUTYPE, TARGET and TARGET_ARCH

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 12579
Build 12854: arc lint + arc unit

Event Timeline

imp created this revision.Nov 7 2017, 6:34 PM
Harbormaster completed remote builds in B12537: Diff 34890.Nov 7 2017, 6:34 PM
imp added a reviewer: emaste.Nov 7 2017, 6:37 PM
bcr added a subscriber: bcr.Nov 7 2017, 7:45 PM

Two textual suggestions. Thanks for documenting this.

share/man/man7/arch.7
347

Hmm, the two instances of internal(ly) sound a bit redundant. Maybe one of these two would fit better?
a) ... there are some internal variables that are used within the build system ...
b) ... there are some variables that are used internally to the build system ...

408

s/names/name/

bdrewery added a subscriber: bdrewery.Nov 7 2017, 9:06 PM
imp added inline comments.Nov 7 2017, 9:11 PM
share/man/man7/arch.7
347

Good point.

408

I originally had 'no standarized names' but made it shorter w/o fixing the plural.

imp added a reviewer: bdrewery.Nov 7 2017, 9:12 PM
bdrewery added inline comments.Nov 7 2017, 9:28 PM
share/man/man7/arch.7
348

I would end at "the build system". The rest feels redundant in a manpage.

394

need to newline wrap the .Dv

410

Does Fx work there like that?

412

It unfortunately is but as you say should not be relied on.

416

newline wrap .Dv

imp added inline comments.Nov 8 2017, 2:36 PM
share/man/man7/arch.7
348

ok

394

I think I can just remove the . and be good. Either way, I'll fix.

410

Yes.

416

OK. Will remove the . or fix.

imp updated this revision to Diff 34944.Nov 8 2017, 2:55 PM

Update, per feedback

Closed by commit rS325749: Document MACHINE, MACHINE_ARCH, CPUTYPE, TARGET and TARGET_ARCH (authored by imp). · Explain WhyNov 13 2017, 12:32 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
share/
man/
man7/
84 lines
tools/
boot/
4 lines

Diff 34944

View Options

share/man/man7/arch.7

Loading...
View Options

tools/boot/universe.sh

Loading...