Zero uninitialized part of struct ptrace_lwpinfo.
ClosedPublic
Actions

Authored by kib on Oct 26 2017, 2:29 PM.

Tags

None

Referenced Files

	F115127756: D12796.id34961.diff
	Sun, Apr 20, 5:46 PM

	Unknown Object (File)
	Sat, Apr 19, 3:04 AM

	Unknown Object (File)
	Sun, Apr 13, 9:01 PM

	Unknown Object (File)
	Tue, Apr 8, 7:14 AM

	Unknown Object (File)
	Feb 6 2025, 6:40 AM

	Unknown Object (File)
	Jan 26 2025, 1:01 PM

	Unknown Object (File)
	Jan 18 2025, 8:54 AM

	Unknown Object (File)
	Dec 25 2024, 9:26 PM

View All 60 Files

Subscribers

imp

Details

Reviewers

jhb

Commits

rS325567: Zero whole struct ptrace_lwpinfo to not leak kernel stack data.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kib created this revision.Oct 26 2017, 2:29 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 26 2017, 2:29 PM

kib mentioned this in D12794: Discard the correct thread event reported for a ptrace stop..Oct 26 2017, 2:31 PM

jhb added inline comments.Nov 6 2017, 8:42 PM

sys/kern/sys_process.c
1370	I would be inclined to zero the whole struct. In my case I saw garbage leak in 'pl_child_pid' for a non-fork event. We should probably zero the entire pl32 before copying across as well in case there is padding (perhaps in fields added in the future)?

Zero the whole struct ptrace_lwpinfo and ptrace_lwpinfo32.

jhb accepted this revision.Nov 8 2017, 10:10 PM

This revision is now accepted and ready to land.Nov 8 2017, 10:10 PM

Closed by commit rS325567: Zero whole struct ptrace_lwpinfo to not leak kernel stack data. (authored by kib). · Explain WhyNov 8 2017, 11:33 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

kern/

sys_process.c

4 lines

Diff 34880

View Options

Zero uninitialized part of struct ptrace_lwpinfo.ClosedPublicActions