Page MenuHomeFreeBSD
Differential D12796

Zero uninitialized part of struct ptrace_lwpinfo.
ClosedPublic
Actions

Authored by kib on Oct 26 2017, 2:29 PM.
Tags
None
Referenced Files
F87039216: D12796.id34355.diff
Fri, Jun 28, 3:27 PM
Unknown Object (File)
Sun, Jun 16, 12:30 PM
Unknown Object (File)
Sun, Jun 16, 11:34 AM
Unknown Object (File)
May 27 2024, 3:45 PM
Unknown Object (File)
May 24 2024, 1:39 AM
Unknown Object (File)
May 24 2024, 1:39 AM
Unknown Object (File)
May 24 2024, 1:39 AM
Unknown Object (File)
May 23 2024, 5:05 PM
View All 35 Files
Subscribers
imp

Details

Reviewers
jhb
Commits
rS325567: Zero whole struct ptrace_lwpinfo to not leak kernel stack data.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib created this revision.Oct 26 2017, 2:29 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 26 2017, 2:29 PM
kib mentioned this in D12794: Discard the correct thread event reported for a ptrace stop..Oct 26 2017, 2:31 PM
jhb added inline comments.Nov 6 2017, 8:42 PM
sys/kern/sys_process.c
1370

I would be inclined to zero the whole struct. In my case I saw garbage leak in 'pl_child_pid' for a non-fork event. We should probably zero the entire pl32 before copying across as well in case there is padding (perhaps in fields added in the future)?

kib updated this revision to Diff 34880.Nov 7 2017, 4:55 PM
kib marked an inline comment as done.

Zero the whole struct ptrace_lwpinfo and ptrace_lwpinfo32.

jhb accepted this revision.Nov 8 2017, 10:10 PM
This revision is now accepted and ready to land.Nov 8 2017, 10:10 PM
Closed by commit rS325567: Zero whole struct ptrace_lwpinfo to not leak kernel stack data. (authored by kib). · Explain WhyNov 8 2017, 11:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
kern/
4 lines

Diff 34880

View Options

sys/kern/sys_process.c

Loading...