Page MenuHomeFreeBSD
Differential D12597

Add a port for Libresonic.
ClosedPublic
Actions

Authored by jlh on Oct 5 2017, 6:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 26, 8:49 AM
Unknown Object (File)
Wed, Dec 25, 2:18 PM
Unknown Object (File)
Sat, Dec 14, 1:34 AM
Unknown Object (File)
Sat, Dec 7, 12:03 PM
Unknown Object (File)
Sat, Nov 30, 2:28 PM
Unknown Object (File)
Fri, Nov 29, 3:51 PM
Unknown Object (File)
Nov 20 2024, 12:49 PM
Unknown Object (File)
Nov 20 2024, 5:25 AM
View All Files
Subscribers
mat

Details

Reviewers
bapt
mat
Commits
rP453870: Add www/libresonic-standalone port.
Summary

This port replicates the existing www/subsonic-standalone and
www/madsonic-standaline. The only difference is that the .war file is provided
directly from the Github project. The .war is not unarchived (as suggested in
the ports handbook) as it conveniently works directly with "java -jar" and I
truss'ed it, it doesn't seem to extract anything but read directly from the war
file.

Test Plan

make all
make install
make deinstall

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 12488
Build 12763: arc lint + arc unit

Event Timeline

jlh created this revision.Oct 5 2017, 6:44 PM
Herald added a subscriber: mat. · View Herald TranscriptOct 5 2017, 6:44 PM
jlh updated this revision to Diff 33728.Oct 5 2017, 6:46 PM

Fix a "Subsonic" leftover in the description.

Harbormaster completed remote builds in B11908: Diff 33728.Oct 5 2017, 6:46 PM
jlh updated this revision to Diff 33730.Oct 5 2017, 9:45 PM

Update rc.d script.

Harbormaster completed remote builds in B11909: Diff 33730.Oct 5 2017, 9:45 PM
mat requested changes to this revision.Oct 6 2017, 3:46 PM
mat added inline comments.
www/libresonic-standalone/Makefile
5–10
PORTNAME=        libresonic
DISTVERSIONPREFIX=  v
DISTVERSION=        6.2
CATEGORIES=        www java
​MASTER_SITES=        https://github.com/Libresonic/libresonic/releases/download/v${DISTVERSION}/
PKGNAMESUFFIX=       -standalone
​EXTRACT_SUFX=        .war
11–14

This should happen way way later.

21–32

Out of order.

47

Not needed.

51–52

Happen too late.

59

Why += ?

80–86

Use ${RLN}

This revision now requires changes to proceed.Oct 6 2017, 3:46 PM
jlh updated this revision to Diff 34385.Oct 27 2017, 6:07 AM
jlh marked 6 inline comments as done.

Update diff after mat@'s review.

Harbormaster completed remote builds in B12259: Diff 34385.Oct 27 2017, 6:07 AM
jlh added inline comments.Oct 27 2017, 6:09 AM
www/libresonic-standalone/Makefile
5–10

Thanks :-). I wanted to stick to what there's in www/madsonic-standalone actually.

11–14

Move it below options.

51–52

I lifted up next to the first block. I don't know where it's supposed to go. Why is it important, BTW?

mat added a comment.Oct 27 2017, 3:50 PM

I don't really understand why you have a pkg-message, and a message-transcoding, and a separator, where they could all be in only one file.

www/libresonic-standalone/Makefile
12

missing empty line before.

14

Missing empty line before.

51–52

To make it easier for anyone to work on any port, there is a standardized way to write things in a Makefile: Chapter 14. Order of Variables in Port Makefiles.

jlh updated this revision to Diff 34409.Oct 27 2017, 8:59 PM
jlh marked 7 inline comments as done.

Update diff with mat@'s second review.

Harbormaster completed remote builds in B12273: Diff 34409.Oct 27 2017, 8:59 PM
jlh added a comment.Oct 27 2017, 8:59 PM

Resolve comment

mat added inline comments.Oct 28 2017, 8:56 AM
www/libresonic-standalone/Makefile
69–74

When using a do-install target, don't use a post-install one, put everything in do-install.

jlh updated this revision to Diff 34629.Nov 1 2017, 8:22 PM

Change post-install targets to do-install.

Harbormaster completed remote builds in B12378: Diff 34629.Nov 1 2017, 8:22 PM
jlh marked an inline comment as done.Nov 1 2017, 8:22 PM
mat added inline comments.Nov 2 2017, 2:32 PM
www/libresonic-standalone/Makefile
6

missing tab after =

59

missing tab after =

jlh updated this revision to Diff 34819.Nov 5 2017, 9:35 AM
jlh marked an inline comment as done.

Add missing tabs.

Harbormaster completed remote builds in B12488: Diff 34819.Nov 5 2017, 9:35 AM
jlh marked an inline comment as done.Nov 5 2017, 9:35 AM
mat accepted this revision.Nov 7 2017, 4:36 PM
This revision is now accepted and ready to land.Nov 7 2017, 4:36 PM
Closed by commit rP453870: Add www/libresonic-standalone port. (authored by jlh). · Explain WhyNov 9 2017, 9:17 PM
This revision was automatically updated to reflect the committed changes.
tobik mentioned this in D13040: Bring www/subsonic-standalone to www/libresonic-standalone's standards..Dec 5 2019, 4:30 PM
tobik mentioned this in D13023: Bring www/madsonic-standalone to www/libresonic-standalone's standards..

Revision Contents
Changeset List

PathSize
www/
libresonic-standalone/
82 lines
3 lines
88 lines
51 lines
9 lines
7 lines

Diff 34819

View Options

www/libresonic-standalone/

Loading...
View Options

www/libresonic-standalone/Makefile

Loading...
View Options

www/libresonic-standalone/distinfo

Loading...
View Options

www/libresonic-standalone/files/

Loading...
View Options

www/libresonic-standalone/files/libresonic.in

Loading...
View Options

www/libresonic-standalone/files/pkg-message.in

Loading...
View Options

www/libresonic-standalone/pkg-descr

Loading...
View Options

www/libresonic-standalone/pkg-plist

Loading...