Page MenuHomeFreeBSD

New port: audio/gxplugins-lv2: Set of LV2 plugins from the guitarix project
ClosedPublic

Authored by yuri on Nov 1 2017, 10:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 19 2024, 12:26 PM
Unknown Object (File)
Feb 11 2024, 7:28 AM
Unknown Object (File)
Dec 21 2023, 11:37 PM
Unknown Object (File)
Dec 20 2023, 6:11 AM
Unknown Object (File)
Dec 12 2023, 1:53 PM
Unknown Object (File)
Dec 2 2023, 8:05 AM
Unknown Object (File)
Nov 29 2023, 11:51 PM
Unknown Object (File)
Nov 23 2023, 1:32 PM
Subscribers

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 12460
Build 12735: arc lint + arc unit

Event Timeline

audio/gxplugins-lv2/Makefile
30

^ https://github.com/brummer10/GxPlugins.lv2/releases/download/v0.3/GxPlugins_v0.3.zip
Why not simply use the release tar ball and save yourself some typing?

yuri marked an inline comment as done.Nov 1 2017, 9:20 PM
yuri added inline comments.
audio/gxplugins-lv2/Makefile
30

Because I wanted to use the latest patches (GH_TAGNAME) that fix some problems with clang not creating shared libs, etc. Modules aren't expanded by github when fetched by tagname.

yuri marked an inline comment as done.Nov 1 2017, 9:20 PM

if it's only a handful patches you could add the commits as patches in files and use the tar-ball -- are there many?

if it's only a handful patches you could add the commits as patches in files and use the tar-ball -- are there many?

There are 8 commits after v0.3.

audio/gxplugins-lv2/Makefile
30

So this is not 0.3 but some other, later, version.

$ git describe --tags 8e39e29
v0.3-7-g8e39e29

Then, please do not set GH_TAGNAME and do:

DISTVERSIONPREFIX= v
DISTVERSION= 0.3-7
DISTVERSIONSUFFIX= -g8e39e29
yuri marked an inline comment as done.Nov 4 2017, 7:41 PM

GH_TAGNAME removed, DISTVERSIONSUFFIX added.

yuri marked an inline comment as done.Nov 6 2017, 6:36 PM
audio/gxplugins-lv2/Makefile
41

Side note, this would probably be a bit more maintainable in case there are different depths of directories in the future:

@${FIND} ${STAGEDIR}${PREFIX}/lib/lv2 -name '*.so' -exec ${STRIP_CMD} {} +
yuri marked an inline comment as done.Nov 7 2017, 5:08 PM
yuri added inline comments.
audio/gxplugins-lv2/Makefile
41

Mat,

This is a good suggestion in general. In this case, LV2 plugins have a fixed structure, so that depth can't change.

yuri marked 2 inline comments as done.Nov 7 2017, 11:03 PM
cat: /proc/cpuinfo: No such file or directory

i have this multiple times during the build

cat: /proc/cpuinfo: No such file or directory

i have this multiple times during the build

Thanks for catching this. I added the patch and the comment to the Makefile, and reported it upstream.

Patched /proc/cpuinfo use in Makefiles.

This revision is now accepted and ready to land.Nov 11 2017, 8:18 AM
This revision was automatically updated to reflect the committed changes.