New port: audio/gxplugins-lv2: Set of LV2 plugins from the guitarix project

[yuri]

Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221596

[tcberner]

audio/gxplugins-lv2/Makefile

29

^ https://github.com/brummer10/GxPlugins.lv2/releases/download/v0.3/GxPlugins_v0.3.zip
Why not simply use the release tar ball and save yourself some typing?

[yuri]

audio/gxplugins-lv2/Makefile

29

Because I wanted to use the latest patches (GH_TAGNAME) that fix some problems with clang not creating shared libs, etc. Modules aren't expanded by github when fetched by tagname.

[tcberner]

if it's only a handful patches you could add the commits as patches in files and use the tar-ball -- are there many?

[yuri]

In D12895#267842, @tcberner wrote:

if it's only a handful patches you could add the commits as patches in files and use the tar-ball -- are there many?

There are 8 commits after v0.3.

[mat]

audio/gxplugins-lv2/Makefile

29

So this is not 0.3 but some other, later, version.

$ git describe --tags 8e39e29
v0.3-7-g8e39e29

Then, please do not set GH_TAGNAME and do:

DISTVERSIONPREFIX= v
DISTVERSION= 0.3-7
DISTVERSIONSUFFIX= -g8e39e29

[yuri]

GH_TAGNAME removed, DISTVERSIONSUFFIX added.

[mat]

audio/gxplugins-lv2/Makefile

42

Side note, this would probably be a bit more maintainable in case there are different depths of directories in the future:

@${FIND} ${STAGEDIR}${PREFIX}/lib/lv2 -name '*.so' -exec ${STRIP_CMD} {} +

[yuri]

audio/gxplugins-lv2/Makefile

42

Mat,

This is a good suggestion in general. In this case, LV2 plugins have a fixed structure, so that depth can't change.

[tcberner]

cat: /proc/cpuinfo: No such file or directory

i have this multiple times during the build

[yuri]

In D12895#270809, @tcberner wrote:

cat: /proc/cpuinfo: No such file or directory

i have this multiple times during the build

Thanks for catching this. I added the patch and the comment to the Makefile, and reported it upstream.

[yuri]

Patched /proc/cpuinfo use in Makefiles.