This new option controls whether to build (and install) LLVM IR versions
of binaries and libraries alongside conventional (ELF) versions. Rather
than depending implicitly on LLVM_LINK being defined, an explicit option
(that errors out if XLLVM_LINK is not provided) is clearer with a more
obvious failure mode. It also provides a clearer signal for future
changes (e.g., the ability to build ELF binaries and libraries via IR
instead of the usual object-file workflow) to depend on.
Details
Details
Diff Detail
Diff Detail
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 12108 Build 12409: arc lint + arc unit
Event Timeline
| share/mk/bsd.lib.mk | ||
|---|---|---|
| 187 | I believe the current convention is to test for == "yes" when that is what you mean. | |
| 189 | test and logic appear to use LLVM_LINK, so the error should refer to that. | |
| share/mk/bsd.prog.mk | ||
| 157 | same comments as for bsd.lib.mk | |
| share/mk/src.opts.mk | ||
| 183 | shouldn't this be in bsd.opts.mk or src.opts.mk but not both? | |
| share/mk/bsd.lib.mk | ||
|---|---|---|
| 187 | share/mk/bsd.opts.mk says:
| |