Add EFI RT support for arm64
ClosedPublic
Actions

Authored by andrew on Oct 5 2017, 11:52 AM.

Details

Reviewers

kib
imp

Group Reviewers

arm64

Commits

Summary

Support the EFI Runtime Services on arm64. As with amd64 we use the 1:1
mapping. This uses the new common code shared with amd64.

The RTC should only be accessed via EFI. There is no locking around it as
the spec only has this as a requirement for the PC-AT CMOS device.

Test Plan

Tested on ThunderX with an EDK based UEFI. Will need testing with U-Boot.

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

kib accepted this revision.Oct 5 2017, 1:17 PM

This revision is now accepted and ready to land.Oct 5 2017, 1:17 PM

imp added inline comments.Oct 5 2017, 4:25 PM

sys/arm64/include/fpu.h
1 ↗	(On Diff #33716)	Need headers on this file. I'd recommend the public domain one because it's just a single #include.
sys/modules/Makefile
707–709 ↗	(On Diff #33716)	This is super ugly. Any chance you can define _efirt twice: once in the amd64 section and once in the aarch64 section? And really, that should be MACHINE == arm64 (there are many mistakes like this in this file, some introduced by me).

This revision now requires review to proceed.Oct 8 2017, 1:55 PM

andrew marked 2 inline comments as done.Oct 8 2017, 1:55 PM

I didn't check that all the MMU stuff was right, but the rest looks good now. thanks for fixing.

sys/arm64/arm64/machdep.c
995 ↗	(On Diff #33817)	I thought that there were extensions to efi to return FDT. Does it not make sense to grab it before we try to load dtb? Or is that detail handled in the boot loader?