perl extension for rxvt-unicode terminal emulator to change font size on the fly
Details
Details
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| x11/urxvt-font-size/Makefile | ||
|---|---|---|
| 4 ↗ | (On Diff #33324) | git describe --tags b9a3c08 says v1.1-14-gb9a3c08, so I think you want DISTVERSIONPREFIX=v and you can remove GH_TAGNAME below. |
| 26–28 ↗ | (On Diff #33324) | Do you need to loop here? It's only installing one file. |
| x11/urxvt-font-size/Makefile | ||
|---|---|---|
| 14 ↗ | (On Diff #33324) | NO_ARCH= yes as well |
| x11/urxvt-font-size/Makefile | ||
|---|---|---|
| 22 ↗ | (On Diff #33324) | dch, you can verify the += isn't necessary with make -VPLIST_FILES. |
| x11/urxvt-font-size/Makefile | ||
|---|---|---|
| 22 ↗ | (On Diff #33324) | no good reason - thanks Mat! |
Comment Actions
incorporate requested changes
- use new upstream git tag
- drop loop
- use NO_ARCH
- fix RUN_DEPENDS
- fix PORTDOCS
- pass portlint -AC brutal feedback
- simplify plist
- waiting on poudriere all the things
Comment Actions
I'd like to add a link in pkg-message to /usr/local/share/doc/urxvt-font-size/README can I use a substitution here too?
Comment Actions
Yes. You need to move pkg-message to files/pkg-message.in and add SUB_FILES=pkg-message. Then inside pkg_message.in, you can use something like
%%DOCSDIR%%/README
Section 8.5. of the Porter's Handbook has a good description.
| x11/urxvt-font-size/Makefile | ||
|---|---|---|
| 19 ↗ | (On Diff #33768) | Nit-picking: It looks like a tab is missing here. Do you want to add one? |
| x11/urxvt-font-size/Makefile | ||
|---|---|---|
| 4 ↗ | (On Diff #33768) | missing tab? |
| x11/urxvt-font-size/Makefile | ||
|---|---|---|
| 19 ↗ | (On Diff #33768) | done - also one for DISTVERSIONPREFIX= too. Is there a rule along the lines of: use vim tabstop=8) and always 1 space even if it looks weird sometimes? |
| x11/urxvt-font-size/Makefile | ||
|---|---|---|
| 19 ↗ | (On Diff #33768) | I see there's tabstop=4 for *.Mk files listed in the handbook but it doesn't seem to be consistent in the ports I've read so far. |
| x11/urxvt-font-size/files/pkg-message.in | ||
|---|---|---|
| 11 ↗ | (On Diff #33790) | Maybe you could put %%DOCSDIR%%/README on a new line? The actual path is long. |
| x11/urxvt-font-size/Makefile | ||
|---|---|---|
| 19 ↗ | (On Diff #33768) | The rule is put at least one tab after the =, and tabs are 8 spaces wide. |