Page MenuHomeFreeBSD
Differential D12463

new port: x11/urxvt-font-size
ClosedPublic
Actions

Authored by dch on Sep 22 2017, 2:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 8, 5:08 AM
Unknown Object (File)
Wed, May 8, 5:08 AM
Unknown Object (File)
Wed, May 8, 5:08 AM
Unknown Object (File)
Wed, May 8, 5:08 AM
Unknown Object (File)
Wed, May 8, 5:08 AM
Unknown Object (File)
Wed, May 8, 5:08 AM
Unknown Object (File)
Wed, May 8, 1:40 AM
Unknown Object (File)
Wed, May 8, 1:40 AM
View All 78 Files
Subscribers
mat

Details

Reviewers
jrm
swills
Commits
rP451471: new port: x11/urxvt-font-size
Summary

perl extension for rxvt-unicode terminal emulator to change font size on the fly

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dch created this revision.Sep 22 2017, 2:28 PM
Herald added a subscriber: mat. · View Herald TranscriptSep 22 2017, 2:28 PM
Harbormaster completed remote builds in B11685: Diff 33322.Sep 22 2017, 2:28 PM
dch updated this revision to Diff 33323.Sep 22 2017, 2:30 PM

appease portlint -AC

Harbormaster completed remote builds in B11686: Diff 33323.Sep 22 2017, 2:30 PM
dch updated this revision to Diff 33324.Sep 22 2017, 2:32 PM

prune extraneous blank lines in pkg-message

Harbormaster completed remote builds in B11687: Diff 33324.Sep 22 2017, 2:33 PM
jrm added inline comments.Sep 22 2017, 3:56 PM
x11/urxvt-font-size/Makefile
4 ↗(On Diff #33324)

git describe --tags b9a3c08 says v1.1-14-gb9a3c08, so I think you want

DISTVERSIONPREFIX=v
DISTVERSION= 1.1-14
DISTVERSIONSUFFIX= -gb9a3c08

and you can remove GH_TAGNAME below.

26–28 ↗(On Diff #33324)

Do you need to loop here? It's only installing one file.

jrm added inline comments.Sep 22 2017, 4:10 PM
x11/urxvt-font-size/Makefile
14 ↗(On Diff #33324)

NO_ARCH= yes as well

mat added inline comments.Sep 22 2017, 5:01 PM
x11/urxvt-font-size/Makefile
12 ↗(On Diff #33324)
​RUN_DEPENDS= urxvt:x11/rxvt-unicode
18 ↗(On Diff #33324)

To use PORTDOCS, you need to add OPTIONS_DEFINE=DOCS.

22 ↗(On Diff #33324)

Why += ?

jrm added inline comments.Sep 22 2017, 8:14 PM
x11/urxvt-font-size/Makefile
22 ↗(On Diff #33324)

dch, you can verify the += isn't necessary with make -VPLIST_FILES.

dch marked 7 inline comments as done.Oct 6 2017, 6:04 PM
dch added inline comments.
x11/urxvt-font-size/Makefile
22 ↗(On Diff #33324)

no good reason - thanks Mat!

dch updated this revision to Diff 33768.Oct 6 2017, 6:24 PM

incorporate requested changes

  • use new upstream git tag
  • drop loop
  • use NO_ARCH
  • fix RUN_DEPENDS
  • fix PORTDOCS
  • pass portlint -AC brutal feedback
  • simplify plist
  • waiting on poudriere all the things
Harbormaster completed remote builds in B11931: Diff 33768.Oct 6 2017, 6:24 PM
dch marked an inline comment as done.Oct 6 2017, 6:28 PM

I'd like to add a link in pkg-message to /usr/local/share/doc/urxvt-font-size/README can I use a substitution here too?

jrm added a comment.Oct 6 2017, 11:27 PM
In D12463#261726, @dch wrote:

I'd like to add a link in pkg-message to /usr/local/share/doc/urxvt-font-size/README can I use a substitution here too?

Yes. You need to move pkg-message to files/pkg-message.in and add SUB_FILES=pkg-message. Then inside pkg_message.in, you can use something like

%%DOCSDIR%%/README

Section 8.5. of the Porter's Handbook has a good description.

x11/urxvt-font-size/Makefile
19 ↗(On Diff #33768)

Nit-picking: It looks like a tab is missing here. Do you want to add one?

dch updated this revision to Diff 33790.Oct 7 2017, 10:54 AM

template out pkg-message and clean up Makefile tabs

Harbormaster completed remote builds in B11943: Diff 33790.Oct 7 2017, 10:54 AM
mat added inline comments.Oct 7 2017, 10:54 AM
x11/urxvt-font-size/Makefile
4 ↗(On Diff #33768)

missing tab?

dch marked an inline comment as done.Oct 7 2017, 10:57 AM
dch added inline comments.
x11/urxvt-font-size/Makefile
19 ↗(On Diff #33768)

done - also one for DISTVERSIONPREFIX= too. Is there a rule along the lines of: use vim tabstop=8) and always 1 space even if it looks weird sometimes?

dch marked an inline comment as done.Oct 7 2017, 11:01 AM
dch added inline comments.
x11/urxvt-font-size/Makefile
19 ↗(On Diff #33768)

I see there's tabstop=4 for *.Mk files listed in the handbook but it doesn't seem to be consistent in the ports I've read so far.

jrm accepted this revision.Oct 7 2017, 11:01 AM
jrm added inline comments.
x11/urxvt-font-size/files/pkg-message.in
11 ↗(On Diff #33790)

Maybe you could put %%DOCSDIR%%/README on a new line? The actual path is long.

This revision is now accepted and ready to land.Oct 7 2017, 11:01 AM
mat added inline comments.Oct 7 2017, 11:02 AM
x11/urxvt-font-size/Makefile
19 ↗(On Diff #33768)

The rule is put at least one tab after the =, and tabs are 8 spaces wide.
For the "looks wierd", YMMV.

dch marked an inline comment as done.Oct 7 2017, 4:25 PM

SHIP IT

Closed by commit rP451471: new port: x11/urxvt-font-size (authored by dch). · Explain WhyOct 7 2017, 6:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
x11/
1 line
urxvt-font-size/
33 lines
3 lines
files/
12 lines
4 lines

Diff 33798

View Options

head/x11/Makefile

Loading...
View Options

head/x11/urxvt-font-size/Makefile

Loading...
View Options

head/x11/urxvt-font-size/distinfo

Loading...
View Options

head/x11/urxvt-font-size/files/pkg-message.in

Loading...
View Options

head/x11/urxvt-font-size/pkg-descr

Loading...