patch(1): Don't overrun line buffer if line is not completely malformed
ClosedPublic
Actions

Authored by kevans on Oct 6 2017, 4:39 PM.

Details

Reviewers

emaste
cem
pfg

Commits

rS324431: patch(1): Don't overrun line buffer in some cases

Summary

Patches like file.txt attached to PR 190195 with a final line formed
like ">(EOL)" could cause a copy past the end of the current line buffer. In the
case of PR 191641, this caused a duplicate line to be copied into the resulting
file.

Instead of running past the end, treat it as if it were a blank line.

PR: 191641

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11926
Build 12258: arc lint + arc unit

Event Timeline

kevans created this revision.Oct 6 2017, 4:39 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 6 2017, 4:39 PM

Harbormaster completed remote builds in B11925: Diff 33761.Oct 6 2017, 4:39 PM

Whoops, it's still possible to run out of memory there, and this looks a little
cleaner

pfg accepted this revision.Oct 7 2017, 3:36 AM

This revision is now accepted and ready to land.Oct 7 2017, 3:36 AM

cem accepted this revision.Oct 8 2017, 4:59 PM

emaste accepted this revision.Oct 9 2017, 12:30 PM

Closed by commit rS324431: patch(1): Don't overrun line buffer in some cases (authored by kevans). · Explain WhyOct 9 2017, 2:50 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

usr.bin/

patch/

pch.c

7 lines

Diff 33762

View Options

patch(1): Don't overrun line buffer if line is not completely malformedClosedPublicActions