mlx4_en: Implement SIOCGIFRSS{KEY,HASH}
ClosedPublic
Actions

Authored by sepherosa_gmail.com on Aug 31 2017, 5:31 AM.

Details

Reviewers

Commits

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

gallatin added inline comments.

sys/dev/mlx4/mlx4_en/mlx4_en_netdev.c
1905 ↗	(On Diff #32537)	Why the ifdefs?

This revision is now accepted and ready to land.Aug 31 2017, 1:14 PM

sys/dev/mlx4/mlx4_en/mlx4_en_netdev.c
1905 ↗	(On Diff #32537)	I was not so sure whether I could MFC D12174 to 10-stable/11-stable or not, but I definitely want to MFC driver bits to 10-stable/11-stable. If D12174 goes well, I probably will MFC it to 10-stable/11-stable. I think adding IOCs does not break ABI.

sys/dev/mlx4/mlx4_en/mlx4_en_netdev.c
2041 ↗	(On Diff #32537)	Hi, Please add a "length" argument to rss_key and optimise away the intermediate "key" storage. --HPS
sys/dev/mlx4/mlx4_en/mlx4_en_rx.c
821 ↗	(On Diff #32537)	BSD-style: 4-space indent after wrap.
846 ↗	(On Diff #32537)	Can you optimise away this temporary storage?

sys/dev/mlx4/mlx4_en/mlx4_en_netdev.c
2041 ↗	(On Diff #32537)	Toeplitz key size is pretty standard. But, sure, I could add a length parameter. As about optimizing away the key, it's fine w/ me; though I will have to say both code you mentioned is not on hot path.
sys/dev/mlx4/mlx4_en/mlx4_en_rx.c
821 ↗	(On Diff #32537)	Heh, OK. This is verbatim copy of the original code.
846 ↗	(On Diff #32537)	Sure.