perl extension for rxvt-unicode terminal emulator to change font size on the fly
Details
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 11686 Build 12032: arc lint + arc unit
Event Timeline
x11/urxvt-font-size/Makefile | ||
---|---|---|
15 | NO_ARCH= yes as well |
x11/urxvt-font-size/Makefile | ||
---|---|---|
23 | dch, you can verify the += isn't necessary with make -VPLIST_FILES. |
x11/urxvt-font-size/Makefile | ||
---|---|---|
23 | no good reason - thanks Mat! |
incorporate requested changes
- use new upstream git tag
- drop loop
- use NO_ARCH
- fix RUN_DEPENDS
- fix PORTDOCS
- pass portlint -AC brutal feedback
- simplify plist
- waiting on poudriere all the things
I'd like to add a link in pkg-message to /usr/local/share/doc/urxvt-font-size/README can I use a substitution here too?
Yes. You need to move pkg-message to files/pkg-message.in and add SUB_FILES=pkg-message. Then inside pkg_message.in, you can use something like
%%DOCSDIR%%/README
Section 8.5. of the Porter's Handbook has a good description.
x11/urxvt-font-size/Makefile | ||
---|---|---|
20 | Nit-picking: It looks like a tab is missing here. Do you want to add one? |
x11/urxvt-font-size/Makefile | ||
---|---|---|
5 | missing tab? |
x11/urxvt-font-size/Makefile | ||
---|---|---|
20 | done - also one for DISTVERSIONPREFIX= too. Is there a rule along the lines of: use vim tabstop=8) and always 1 space even if it looks weird sometimes? |
x11/urxvt-font-size/Makefile | ||
---|---|---|
20 | I see there's tabstop=4 for *.Mk files listed in the handbook but it doesn't seem to be consistent in the ports I've read so far. |
x11/urxvt-font-size/files/pkg-message.in | ||
---|---|---|
11 ↗ | (On Diff #33790) | Maybe you could put %%DOCSDIR%%/README on a new line? The actual path is long. |
x11/urxvt-font-size/Makefile | ||
---|---|---|
20 | The rule is put at least one tab after the =, and tabs are 8 spaces wide. |