Page MenuHomeFreeBSD

new port: x11/urxvt-font-size
ClosedPublic

Authored by dch on Sep 22 2017, 2:28 PM.
Tags
None
Referenced Files
F102854534: D12463.id33798.diff
Mon, Nov 18, 12:59 AM
Unknown Object (File)
Fri, Nov 1, 4:55 PM
Unknown Object (File)
Fri, Nov 1, 8:28 AM
Unknown Object (File)
Sun, Oct 27, 7:44 AM
Unknown Object (File)
Oct 16 2024, 6:55 PM
Unknown Object (File)
Sep 28 2024, 10:01 PM
Unknown Object (File)
Sep 28 2024, 6:03 PM
Unknown Object (File)
Sep 26 2024, 11:02 AM
Subscribers

Details

Summary

perl extension for rxvt-unicode terminal emulator to change font size on the fly

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 11686
Build 12032: arc lint + arc unit

Event Timeline

prune extraneous blank lines in pkg-message

x11/urxvt-font-size/Makefile
5

git describe --tags b9a3c08 says v1.1-14-gb9a3c08, so I think you want

DISTVERSIONPREFIX=v
DISTVERSION= 1.1-14
DISTVERSIONSUFFIX= -gb9a3c08

and you can remove GH_TAGNAME below.

27–29

Do you need to loop here? It's only installing one file.

x11/urxvt-font-size/Makefile
15

NO_ARCH= yes as well

x11/urxvt-font-size/Makefile
13
​RUN_DEPENDS= urxvt:x11/rxvt-unicode
19

To use PORTDOCS, you need to add OPTIONS_DEFINE=DOCS.

23

Why += ?

x11/urxvt-font-size/Makefile
23

dch, you can verify the += isn't necessary with make -VPLIST_FILES.

dch marked 7 inline comments as done.Oct 6 2017, 6:04 PM
dch added inline comments.
x11/urxvt-font-size/Makefile
23

no good reason - thanks Mat!

incorporate requested changes

  • use new upstream git tag
  • drop loop
  • use NO_ARCH
  • fix RUN_DEPENDS
  • fix PORTDOCS
  • pass portlint -AC brutal feedback
  • simplify plist
  • waiting on poudriere all the things
dch marked an inline comment as done.Oct 6 2017, 6:28 PM

I'd like to add a link in pkg-message to /usr/local/share/doc/urxvt-font-size/README can I use a substitution here too?

In D12463#261726, @dch wrote:

I'd like to add a link in pkg-message to /usr/local/share/doc/urxvt-font-size/README can I use a substitution here too?

Yes. You need to move pkg-message to files/pkg-message.in and add SUB_FILES=pkg-message. Then inside pkg_message.in, you can use something like

%%DOCSDIR%%/README

Section 8.5. of the Porter's Handbook has a good description.

x11/urxvt-font-size/Makefile
20

Nit-picking: It looks like a tab is missing here. Do you want to add one?

template out pkg-message and clean up Makefile tabs

x11/urxvt-font-size/Makefile
5

missing tab?

dch marked an inline comment as done.Oct 7 2017, 10:57 AM
dch added inline comments.
x11/urxvt-font-size/Makefile
20

done - also one for DISTVERSIONPREFIX= too. Is there a rule along the lines of: use vim tabstop=8) and always 1 space even if it looks weird sometimes?

dch marked an inline comment as done.Oct 7 2017, 11:01 AM
dch added inline comments.
x11/urxvt-font-size/Makefile
20

I see there's tabstop=4 for *.Mk files listed in the handbook but it doesn't seem to be consistent in the ports I've read so far.

jrm added inline comments.
x11/urxvt-font-size/files/pkg-message.in
11 ↗(On Diff #33790)

Maybe you could put %%DOCSDIR%%/README on a new line? The actual path is long.

This revision is now accepted and ready to land.Oct 7 2017, 11:01 AM
x11/urxvt-font-size/Makefile
20

The rule is put at least one tab after the =, and tabs are 8 spaces wide.
For the "looks wierd", YMMV.

This revision was automatically updated to reflect the committed changes.