Page MenuHomeFreeBSD

lang/php73: Simplify with options framework
Needs ReviewPublic

Authored by brnrd on Sep 17 2017, 3:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 18, 7:43 PM
Unknown Object (File)
Jan 14 2024, 1:13 AM
Unknown Object (File)
Dec 22 2023, 11:03 PM
Unknown Object (File)
Dec 10 2023, 10:17 PM
Unknown Object (File)
Dec 1 2023, 11:15 PM
Unknown Object (File)
Nov 15 2023, 6:27 AM
Unknown Object (File)
Nov 14 2023, 7:52 AM
Unknown Object (File)
Nov 10 2023, 9:24 PM
Subscribers

Details

Reviewers
tz
mat
ale
Summary
lang/php72: Simplify with options framework

 - Convert all PORT_OPTIONS:M checks to OPT_something
 - Order alphabetically where possible
 - Fold double PHP_MODNAME checks into one

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 11626
Build 11974: arc lint + arc unit

Event Timeline

lang/php71/Makefile
25

USE_AUTOTOOLS is deprecatd, it should be really better to make it work with USES=autoreconf.

79

debug leftover ?

brnrd marked an inline comment as done.

Small fixups

brnrd added inline comments.
lang/php71/Makefile
25

I know.
Tried building it with USES= autoreconf but that results in a libtool version error
Trying to find a PR for it...

lang/php71/Makefile
79

No such thing as USES=apache. It is always better to not mix 50 different kind of changes in a patch. Especially in case of a new USES where the old usage is not removed and would probably be better off being done in batch.

Also note that 2.2+ is irrelevant, the only versions we have are 2.2 and 2.4, and 2.2 is deprecated so it will soon be 2.4 only.

157

Makefile.ext does not .include <bsd.port.mk> put it back at the end.

mat requested changes to this revision.Mar 12 2018, 10:16 AM
mat added inline comments.
lang/php72/Makefile
100–101 ↗(On Diff #40178)

Options helper must no be defined after including bsd.port.options.mk.

This revision now requires changes to proceed.Mar 12 2018, 10:16 AM

OPT_* before bsd.port.pre.mk

Turns out the include of apache.mk is not needed at all.
It seems to have been there so APXS is defined, this is no longer
a requirement. Include moves down to just before where options
need checking

Additionally for Makefile.ext:

  • Remove _DESC that are in Mk/bsd.options.desc.mk
  • Fix faulty REGEX_REGEX_*
brnrd retitled this revision from lang/php71: Simplify with options framework to lang/php72: Simplify with options framework.Mar 19 2018, 8:54 PM

Hi @tz, @ale,

Can you provide feedback on this review? I think I can commit this under "Approved by: infrastructure modernization blanket"

Rather have your feedback and support though...

Cheers, Bernard.

Aloha Bernard,
i will take a look at it next week. I'm currently on very low time, but will try to through all your PHP reviews (i'm assigned to) next week.
Thanks,
Torsten

Aloha Bernard,
i'm very sorry that this ticket is stuck. Since i will be away for some time, i took a short, but not too deep, look at it. It will need an rebase, but i can't see any showstopper or obvious issues. So: please go ahead and big thank you for your work and patience!
Greetings,
Torsten

brnrd retitled this revision from lang/php72: Simplify with options framework to lang/php73: Simplify with options framework.Nov 16 2018, 11:35 AM
brnrd edited the summary of this revision. (Show Details)

Remove crud, restore CONFLICTS

I have a few doubts, see my comments

lang/php73/Makefile
64 ↗(On Diff #50485)

This looks duplicated, line 54

68 ↗(On Diff #50485)

Why php_sapi is lowercase? There are many others below.

69 ↗(On Diff #50485)

Why not using XXX_CONFIGURE_ENABLE=cgi ? There are other occurrences below

90 ↗(On Diff #50485)

Why --with-apx2=${APXS} was removed?