Fix problems with iflib when !EARLY_AP_STARTUP
AbandonedPublic
Actions

Authored by shurd on Sep 15 2017, 7:08 PM.

Details

Reviewers

sbruno
kmacy

Summary

We should not call taskqgroup_adjust_deferred() until after theqgroups are initialized. The MPASS() from the caller should alsobe conditiional on EARLY_AP_STARTUP (or removed).Error introduced in the giant iflib rollup patch r323516

Don't call taskqgroup_adjust_deferred() until the tqgroups
are initialized. Don't assert if it's not called.

Test Plan

Test on existing systems as well as ones that were failing
after r323516

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11590
Build 11943: arc lint + arc unit

Event Timeline

shurd created this revision.Sep 15 2017, 7:08 PM

Harbormaster completed remote builds in B11590: Diff 33119.Sep 15 2017, 7:08 PM

Herald added subscribers: ae, imp. · View Herald TranscriptSep 15 2017, 7:08 PM

shurd retitled this revision from Fix problems with iflib when !EARLY_AP_STARTUP We should not call taskqgroup_adjust_deferred() until after the qgroups are initialized. The MPASS() from the caller should also be conditiional on EARLY_AP_STARTUP (or removed). Error introduced... to Fix problems with iflib when !EARLY_AP_STARTUP.Sep 15 2017, 7:12 PM

shurd edited the summary of this revision. (Show Details)

Fails for me:

https://pastebin.com/Yuhc8dgm