x86 MCA: Extract CMCI support predicate into function
ClosedPublic
Actions

Authored by cem on Sep 11 2017, 4:23 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Jan 16, 7:40 AM

	Unknown Object (File)
	Wed, Jan 14, 10:02 AM

	Unknown Object (File)
	Thu, Jan 8, 4:37 PM

	Unknown Object (File)
	Thu, Jan 8, 3:17 AM

	Unknown Object (File)
	Tue, Jan 6, 5:22 AM

	Unknown Object (File)
	Wed, Dec 31, 12:40 AM

	Unknown Object (File)
	Dec 9 2025, 9:04 PM

	Unknown Object (File)
	Nov 21 2025, 1:41 AM

View All 79 Files

Subscribers

None

Details

Reviewers

avg
kib
jhb
markj

Commits

rS323462: x86 MCA: Extract CMCI support predicate into function

Summary

On AMD, the MCG_CAP feature bit is reserved -- not explicitly zero. Do not
use it to determine CMCI support.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cem created this revision.Sep 11 2017, 4:23 PM

Harbormaster completed remote builds in B11493: Diff 32921.Sep 11 2017, 4:23 PM

markj added inline comments.Sep 11 2017, 5:50 PM

sys/x86/x86/mca.c
337 ↗	(On Diff #32921)	This won't compile if DEV_APIC isn't defined.

Fix build on !DEV_APIC

markj accepted this revision.Sep 11 2017, 6:07 PM

This revision is now accepted and ready to land.Sep 11 2017, 6:07 PM

LGTM

Closed by commit rS323462: x86 MCA: Extract CMCI support predicate into function (authored by cem). · Explain WhySep 11 2017, 8:41 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

x86/

mca.c

18 lines

Diff 32936

View Options

x86 MCA: Extract CMCI support predicate into functionClosedPublicActions