Page MenuHomeFreeBSD
Differential D12320

x86 MCA: Extract CMCI support predicate into function
ClosedPublic
Actions

Authored by cem on Sep 11 2017, 4:23 PM.
Tags
None
Referenced Files
F150615384: D12320.id32936.diff
Thu, Apr 2, 8:14 PM
F150571627: D12320.id32936.diff
Thu, Apr 2, 11:41 AM
Unknown Object (File)
Fri, Mar 27, 1:25 PM
Unknown Object (File)
Fri, Mar 27, 6:05 AM
Unknown Object (File)
Fri, Mar 27, 1:51 AM
Unknown Object (File)
Thu, Mar 26, 5:33 PM
Unknown Object (File)
Wed, Mar 25, 8:30 AM
Unknown Object (File)
Tue, Mar 24, 1:27 PM
View All 100 Files
Subscribers
None

Details

Reviewers
avg
kib
jhb
markj
Commits
rS323462: x86 MCA: Extract CMCI support predicate into function
Summary

On AMD, the MCG_CAP feature bit is reserved -- not explicitly zero. Do not
use it to determine CMCI support.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 11498
Build 11853: arc lint + arc unit

Event Timeline

cem created this revision.Sep 11 2017, 4:23 PM
Harbormaster completed remote builds in B11493: Diff 32921.Sep 11 2017, 4:23 PM
markj added inline comments.Sep 11 2017, 5:50 PM
sys/x86/x86/mca.c
337

This won't compile if DEV_APIC isn't defined.

cem updated this revision to Diff 32929.Sep 11 2017, 6:01 PM
cem marked an inline comment as done.

Fix build on !DEV_APIC

markj accepted this revision.Sep 11 2017, 6:07 PM
This revision is now accepted and ready to land.Sep 11 2017, 6:07 PM
avg accepted this revision.Sep 11 2017, 8:08 PM

LGTM

Closed by commit rS323462: x86 MCA: Extract CMCI support predicate into function (authored by cem). · Explain WhySep 11 2017, 8:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
x86/
x86/
18 lines

Diff 32929

View Options

sys/x86/x86/mca.c

Loading...