Differential D12176

mlx4_en: Implement SIOCGIFRSS{KEY,HASH}
ClosedPublic
Actions

Authored by sepherosa_gmail.com on Aug 31 2017, 5:31 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Oct 21, 4:47 AM

	Unknown Object (File)
	Tue, Oct 14, 8:38 AM

	Unknown Object (File)
	Sat, Oct 11, 6:43 AM

	Unknown Object (File)
	Sun, Oct 5, 3:21 AM

	Unknown Object (File)
	Wed, Oct 1, 1:07 AM

	Unknown Object (File)
	Sep 17 2025, 1:56 AM

	Unknown Object (File)
	Sep 9 2025, 12:20 AM

	Unknown Object (File)
	Sep 5 2025, 8:06 PM

Subscribers

None

Details

Reviewers

• hselasky
adrian
rwatson
glebius
gallatin

Commits

rS324200: Implement SIOCGIFRSS{KEY,HASH} for the mlx4en(4) driver.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

sepherosa_gmail.com created this revision.Aug 31 2017, 5:31 AM

gallatin accepted this revision.Aug 31 2017, 1:14 PM

gallatin added inline comments.

sys/dev/mlx4/mlx4_en/mlx4_en_netdev.c
1905	Why the ifdefs?

This revision is now accepted and ready to land.Aug 31 2017, 1:14 PM

sepherosa_gmail.com added inline comments.Sep 1 2017, 12:54 AM

sys/dev/mlx4/mlx4_en/mlx4_en_netdev.c
1905	I was not so sure whether I could MFC D12174 to 10-stable/11-stable or not, but I definitely want to MFC driver bits to 10-stable/11-stable. If D12174 goes well, I probably will MFC it to 10-stable/11-stable. I think adding IOCs does not break ABI.

• hselasky added inline comments.Sep 6 2017, 2:12 PM

sys/dev/mlx4/mlx4_en/mlx4_en_netdev.c
2041	Hi, Please add a "length" argument to rss_key and optimise away the intermediate "key" storage. --HPS
sys/dev/mlx4/mlx4_en/mlx4_en_rx.c
821	BSD-style: 4-space indent after wrap.
856	Can you optimise away this temporary storage?

sepherosa_gmail.com added inline comments.Sep 7 2017, 2:29 AM

sys/dev/mlx4/mlx4_en/mlx4_en_netdev.c
2041	Toeplitz key size is pretty standard. But, sure, I could add a length parameter. As about optimizing away the key, it's fine w/ me; though I will have to say both code you mentioned is not on hot path.
sys/dev/mlx4/mlx4_en/mlx4_en_rx.c
821	Heh, OK. This is verbatim copy of the original code.
856	Sure.

Address Hans' comment

This revision now requires review to proceed.Sep 7 2017, 3:05 AM

Thank you. Currently reviewing this patch in Mellanox.

With some modifications.

This revision is now accepted and ready to land.Oct 2 2017, 12:02 PM

Closed by commit rS324200: Implement SIOCGIFRSS{KEY,HASH} for the mlx4en(4) driver. (authored by • hselasky). · Explain WhyOct 2 2017, 12:06 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

mlx4/

mlx4_en/

2 lines

mlx4_en_netdev.c

46 lines

47 lines

Diff 32753

sys/dev/mlx4/mlx4_en/en.h

Loading...

sys/dev/mlx4/mlx4_en/mlx4_en_netdev.c

Loading...

sys/dev/mlx4/mlx4_en/mlx4_en_rx.c

Loading...