Remove spaces from CTL devices' default serial numbers
ClosedPublic
Actions

Authored by asomers on Sep 6 2017, 9:57 PM.

Details

Reviewers

ken
mav

Commits

rS323503: Remove spaces from CTL devices' default serial numbers

Summary

Remove spaces from CTL devices' default serial numbers

It's awkward to have spaces in CAM device serial numbers. That leads to
such things as device nodes named "/dev/diskid/MYSERIAL%20%20%201". Better
to replace the spaces with "0"s. This change only affects the default
serial numbers for users who don't provide their own.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11407
Build 11767: arc lint + arc unit

Event Timeline

asomers created this revision.Sep 6 2017, 9:57 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 6 2017, 9:57 PM

Harbormaster completed remote builds in B11407: Diff 32750.Sep 6 2017, 9:57 PM

Looks good to me, thanks!

This revision is now accepted and ready to land.Sep 7 2017, 8:22 PM

asomers added subscribers: mav, trasz.Sep 7 2017, 8:26 PM

I have no objections against the change. Though the whole concept of using so simple and repeatable LUN IDs is a request for troubles caused by conflicts.

Closed by commit rS323503: Remove spaces from CTL devices' default serial numbers (authored by asomers). · Explain WhySep 12 2017, 7:36 PM

This revision was automatically updated to reflect the committed changes.