Page MenuHomeFreeBSD
Differential D12221

Skylake server core PMC support for hwpmc(4)
ClosedPublic
Actions

Authored by kib on Sep 3 2017, 3:22 PM.
Tags
None
Referenced Files
F110539252: D12221.diff
Wed, Feb 19, 9:07 PM
Unknown Object (File)
Tue, Feb 18, 1:24 PM
Unknown Object (File)
Wed, Jan 29, 7:58 PM
Unknown Object (File)
Jan 20 2025, 7:42 PM
Unknown Object (File)
Jan 4 2025, 12:08 AM
Unknown Object (File)
Dec 4 2024, 7:07 PM
Unknown Object (File)
Nov 28 2024, 9:38 PM
Unknown Object (File)
Nov 17 2024, 9:10 PM
View All 58 Files
Subscribers
emaste
gnn
imp

Details

Reviewers
rstone
Commits
rS323230: Skylake server core PMC support for hwpmc(4).
Test Plan

This version passes pmctest.py.

I also looked at some most interesting counters like machine restarts with pmcstat in top mode, which also look reasonable.

Tested on Intel(R) Xeon(R) Platinum 8170 CPU

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib created this revision.Sep 3 2017, 3:22 PM
Herald added subscribers: gnn, imp. · View Herald TranscriptSep 3 2017, 3:22 PM
kib updated this revision to Diff 32625.Sep 3 2017, 3:56 PM
kib edited the test plan for this revision. (Show Details)
kib edited the test plan for this revision. (Show Details)Sep 3 2017, 3:59 PM
kib added a reviewer: rstone.
emaste added a comment.Sep 5 2017, 8:17 PM

Without comparing entries against documentation this looks reasonable to my eye.

Closed by commit rS323230: Skylake server core PMC support for hwpmc(4). (authored by kib). · Explain WhySep 6 2017, 5:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
lib/
libpmc/
35 lines
sys/
dev/
hwpmc/
498 lines
6 lines
290 lines

Diff 32625

View Options

lib/libpmc/libpmc.c

Loading...
View Options

sys/dev/hwpmc/hwpmc_core.c

Loading...
View Options

sys/dev/hwpmc/hwpmc_intel.c

Loading...
View Options

sys/dev/hwpmc/pmc_events.h

Loading...