Page MenuHomeFreeBSD
Differential D11690

Introduce flopenat(3) function.
ClosedPublic
Actions

Authored by oshogbo on Jul 21 2017, 6:14 PM.
Tags
None
Referenced Files
F136982062: D11690.id31579.diff
Thu, Nov 20, 9:59 PM
F136979764: D11690.id31069.diff
Thu, Nov 20, 9:49 PM
F136979733: D11690.id31323.diff
Thu, Nov 20, 9:49 PM
F136979554: D11690.id31064.diff
Thu, Nov 20, 9:49 PM
F136979293: D11690.id31066.diff
Thu, Nov 20, 9:48 PM
F136979189: D11690.id31303.diff
Thu, Nov 20, 9:47 PM
F136979117: D11690.id.diff
Thu, Nov 20, 9:47 PM
F136979015: D11690.id31198.diff
Thu, Nov 20, 9:46 PM
View All Files
Subscribers
None

Details

Reviewers
des
emaste
allanjude
Commits
rS322054: Introduce the flopenat(3) function.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

oshogbo created this revision.Jul 21 2017, 6:14 PM
oshogbo retitled this revision from Introcude flopenat(3) function. to Introduce flopenat(3) function..
oshogbo updated this revision to Diff 31066.Jul 21 2017, 7:09 PM

Small fix to man page.

oshogbo updated this revision to Diff 31069.Jul 21 2017, 7:17 PM

Sorry guys for spam ;/
Regenerate with -U99999

des added inline comments.Jul 24 2017, 7:58 AM
lib/libutil/flopen.3
32 ↗(On Diff #31069)

only one name per line

lib/libutil/flopen.c
55–57 ↗(On Diff #31069)

these three lines can remain here, they have no bearing on the varargs code

lib/libutil/libutil.h
96 ↗(On Diff #31069)

please follow the leading-underscore convention for argument names

oshogbo updated this revision to Diff 31198.Jul 25 2017, 8:31 PM
oshogbo marked 2 inline comments as done.

Update after des@ review.

oshogbo marked an inline comment as done.Jul 25 2017, 8:31 PM
emaste edited edge metadata.Jul 25 2017, 9:32 PM

Should the man page document AT_FDCWD?

This LGTM, with @des's approval.

des edited edge metadata.Jul 28 2017, 11:13 AM

I guess you could copy the sentence about AT_FDCWD from openat(2).

BTW, it just occurred to me that you can avoid the duplicate O_CREAT logic by simply passing ap to flopenatm(), which you can then rename vflopenat() (v for va_list, like vfprintf(), instead of m for mode).

oshogbo updated this revision to Diff 31303.Jul 28 2017, 11:43 AM
In D11690#243240, @emaste wrote:

Should the man page document AT_FDCWD?

This LGTM, with @des's approval.

Done.

In D11690#243927, @des wrote:

I guess you could copy the sentence about AT_FDCWD from openat(2).

Done.

In D11690#243927, @des wrote:

BTW, it just occurred to me that you can avoid the duplicate O_CREAT logic by simply passing ap to flopenatm(), which you can then rename vflopenat() (v for va_list, like vfprintf(), instead of m for mode).

Duh ofc... Thanks!!!

des added a comment.Jul 28 2017, 2:58 PM

Just a few nits before I approve this :)

lib/libutil/flopen.c
126–127 ↗(On Diff #31303)

per style(9), ap goes first.

132 ↗(On Diff #31303)

per style(9), no blank line here.

139–140 ↗(On Diff #31303)

per style(9), ap goes first.

145 ↗(On Diff #31303)

per style(9), no blank line here.

oshogbo updated this revision to Diff 31323.Jul 28 2017, 7:37 PM
oshogbo marked 4 inline comments as done.

Style fixes.

des accepted this revision.Aug 3 2017, 11:12 AM
This revision is now accepted and ready to land.Aug 3 2017, 11:12 AM
Closed by commit rS322054: Introduce the flopenat(3) function. (authored by oshogbo). · Explain WhyAug 4 2017, 2:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
lib/
libutil/
1 line
30 lines
36 lines
1 line

Diff 31579

View Options

head/lib/libutil/Makefile

Loading...
View Options

head/lib/libutil/flopen.3

Loading...
View Options

head/lib/libutil/flopen.c

Loading...
View Options

head/lib/libutil/libutil.h

Loading...