Details

Reviewers

des
emaste
allanjude

Commits

rS322054: Introduce the flopenat(3) function.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

oshogbo created this revision.Jul 21 2017, 6:14 PM

oshogbo retitled this revision from Introcude flopenat(3) function. to Introduce flopenat(3) function..

Small fix to man page.

Sorry guys for spam ;/
Regenerate with -U99999

des added inline comments.Jul 24 2017, 7:58 AM

lib/libutil/flopen.3
32–33	only one name per line
lib/libutil/flopen.c
55–57	these three lines can remain here, they have no bearing on the varargs code
lib/libutil/libutil.h
96	please follow the leading-underscore convention for argument names

Update after des@ review.

oshogbo marked an inline comment as done.Jul 25 2017, 8:31 PM

Should the man page document AT_FDCWD?

This LGTM, with @des's approval.

I guess you could copy the sentence about AT_FDCWD from openat(2).

BTW, it just occurred to me that you can avoid the duplicate O_CREAT logic by simply passing ap to flopenatm(), which you can then rename vflopenat() (v for va_list, like vfprintf(), instead of m for mode).

In D11690#243240, @emaste wrote:

Should the man page document AT_FDCWD?

This LGTM, with @des's approval.

Done.

In D11690#243927, @des wrote:

I guess you could copy the sentence about AT_FDCWD from openat(2).

Done.

In D11690#243927, @des wrote:

BTW, it just occurred to me that you can avoid the duplicate O_CREAT logic by simply passing ap to flopenatm(), which you can then rename vflopenat() (v for va_list, like vfprintf(), instead of m for mode).

Duh ofc... Thanks!!!

Just a few nits before I approve this :)

lib/libutil/flopen.c
120–121	per `style(9)`, `ap` goes first.
126	per `style(9)`, no blank line here.
133–134	per `style(9)`, `ap` goes first.
139	per `style(9)`, no blank line here.

Style fixes.

des accepted this revision.Aug 3 2017, 11:12 AM

This revision is now accepted and ready to land.Aug 3 2017, 11:12 AM

Closed by commit rS322054: Introduce the flopenat(3) function. (authored by oshogbo). · Explain WhyAug 4 2017, 2:24 PM

This revision was automatically updated to reflect the committed changes.

Introduce flopenat(3) function.
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 31198

lib/libutil/Makefile

lib/libutil/flopen.3

lib/libutil/flopen.c

lib/libutil/libutil.h

Introduce flopenat(3) function.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 31198

lib/libutil/Makefile

lib/libutil/flopen.3

lib/libutil/flopen.c

lib/libutil/libutil.h

Introduce flopenat(3) function.
ClosedPublic
Actions

Revision Contents
Changeset List