Page MenuHomeFreeBSD
Differential D11713

Fix DTrace test case: common.misc.t_dtrace_contrib.tst_macroglob_ksh
ClosedPublic
Actions

Authored by lwhsu on Jul 24 2017, 12:40 PM.
Tags
None
Referenced Files
F106063417: D11713.diff
Tue, Dec 24, 6:44 PM
Unknown Object (File)
Thu, Nov 28, 9:39 PM
Unknown Object (File)
Nov 17 2024, 4:26 AM
Unknown Object (File)
Nov 15 2024, 6:54 AM
Unknown Object (File)
Oct 2 2024, 5:09 PM
Unknown Object (File)
Oct 2 2024, 3:09 PM
Unknown Object (File)
Oct 2 2024, 6:38 AM
Unknown Object (File)
Sep 30 2024, 1:29 AM
View All 41 Files
Subscribers
imp

Details

Reviewers
gnn
markj
ngie
Commits
rS321470: Modify glob patterns and expected output to match FreeBSD's implementation.
Summary

This case does glob on syscalls, and fails on FreeBSD because of syscall set differs than Solaris.

Modify glob patterns and expected output to match FreeBSD's implementation.

Test Plan

cd /usr/tests/cddl/usr.sbin/dtrace/common/misc && kyua debug t_dtrace_contrib:tst_macroglob_ksh

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 10651
Build 11055: arc lint + arc unit

Event Timeline

lwhsu created this revision.Jul 24 2017, 12:40 PM
Herald added 1 blocking reviewer(s): gnn. · View Herald TranscriptJul 24 2017, 12:40 PM
Herald added a subscriber: imp. · View Herald Transcript
Harbormaster completed remote builds in B10639: Diff 31127.Jul 24 2017, 12:40 PM
lwhsu edited the summary of this revision. (Show Details)Jul 24 2017, 12:41 PM
lwhsu edited the summary of this revision. (Show Details)
markj added inline comments.Jul 24 2017, 6:59 PM
cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/misc/tst.macroglob.ksh
34–40

I find it a bit easier to read if the pipe comes before the newline, as you did in the final dtrace invocation.

markj accepted this revision.Jul 24 2017, 6:59 PM
lwhsu updated this revision to Diff 31147.Jul 24 2017, 10:21 PM
lwhsu edited edge metadata.

format

Harbormaster completed remote builds in B10651: Diff 31147.Jul 24 2017, 10:21 PM
lwhsu marked an inline comment as done.Jul 24 2017, 10:21 PM
lwhsu added inline comments.
cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/misc/tst.macroglob.ksh
34–40

right, I reformatted them but missed this one.

ngie accepted this revision.Jul 24 2017, 10:24 PM
markj accepted this revision.Jul 24 2017, 10:25 PM
gnn accepted this revision.Jul 25 2017, 10:24 AM
This revision is now accepted and ready to land.Jul 25 2017, 10:24 AM
Closed by commit rS321470: Modify glob patterns and expected output to match FreeBSD's implementation. (authored by lwhsu). · Explain WhyJul 25 2017, 1:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
cddl/
contrib/
opensolaris/
cmd/
dtrace/
test/
tst/
common/
misc/
13 lines
9 lines

Diff 31147

View Options

cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/misc/tst.macroglob.ksh

Loading...
View Options

cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/misc/tst.macroglob.ksh.out

Loading...