Remove some private symbols from librt
ClosedPublic
Actions

Authored by asomers on Jul 18 2017, 11:23 PM.

Details

Reviewers

kib
jhb

Commits

rS321295: Remove some private symbols from librt

Summary

Remove some private symbols from librt

Private functions like __aio_read and _aio_read were exposed in
FBSDprivate_1.0 by r169090, even though they've never been used outside of
librt. Also, remove some weak references from r156136 that have never
resolved.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10567
Build 10974: arc lint + arc unit

Event Timeline

asomers created this revision.Jul 18 2017, 11:23 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 18 2017, 11:23 PM

Harbormaster completed remote builds in B10562: Diff 30934.Jul 18 2017, 11:23 PM

There are parallel exports from libc private namespace, similar to lio_listio.

I do not quite understand the original motivation for providing exported _aio (and broken) symbols from libc. IMO if removing _aio from librt, libc private export should be cleared as well.

In D11649#241332, @kib wrote:

There are parallel exports from libc private namespace, similar to lio_listio.

I do not quite understand the original motivation for providing exported _aio (and broken) symbols from libc. IMO if removing _aio from librt, libc private export should be cleared as well.

Good catch. I'll remove them too.

Remove nonexistent symbols from libc's private namespace too

kib accepted this revision.Jul 20 2017, 6:41 AM

This revision is now accepted and ready to land.Jul 20 2017, 6:41 AM

Closed by commit rS321295: Remove some private symbols from librt (authored by asomers). · Explain WhyJul 20 2017, 4:24 PM

This revision was automatically updated to reflect the committed changes.