Page MenuHomeFreeBSD

Remove some private symbols from librt
ClosedPublic

Authored by asomers on Jul 18 2017, 11:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 2:54 PM
Unknown Object (File)
Mar 22 2024, 10:16 PM
Unknown Object (File)
Mar 22 2024, 10:16 PM
Unknown Object (File)
Mar 22 2024, 10:16 PM
Unknown Object (File)
Mar 22 2024, 10:16 PM
Unknown Object (File)
Mar 8 2024, 8:27 AM
Unknown Object (File)
Feb 23 2024, 8:32 PM
Unknown Object (File)
Jan 8 2024, 8:54 PM
Subscribers

Details

Summary

Remove some private symbols from librt

Private functions like __aio_read and _aio_read were exposed in
FBSDprivate_1.0 by r169090, even though they've never been used outside of
librt. Also, remove some weak references from r156136 that have never
resolved.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib edited edge metadata.

There are parallel exports from libc private namespace, similar to lio_listio.

I do not quite understand the original motivation for providing exported _aio (and broken) symbols from libc. IMO if removing _aio from librt, libc private export should be cleared as well.

In D11649#241332, @kib wrote:

There are parallel exports from libc private namespace, similar to lio_listio.

I do not quite understand the original motivation for providing exported _aio (and broken) symbols from libc. IMO if removing _aio from librt, libc private export should be cleared as well.

Good catch. I'll remove them too.

Remove nonexistent symbols from libc's private namespace too

This revision is now accepted and ready to land.Jul 20 2017, 6:41 AM
This revision was automatically updated to reflect the committed changes.