vdevice.h: avoid gcc variably-modified warning
ClosedPublic
Actions

Authored by rlibby on Jun 29 2017, 9:39 PM.

Tags

None

Referenced Files

	F167318225: D11416.diff
	Thu, Aug 20, 9:08 PM

	Unknown Object (File)
	Wed, Aug 19, 11:11 AM

	Unknown Object (File)
	Tue, Aug 18, 6:14 PM

	Unknown Object (File)
	Tue, Aug 18, 7:51 AM

	Unknown Object (File)
	Fri, Aug 14, 3:07 PM

	Unknown Object (File)
	Jul 21 2026, 10:35 PM

	Unknown Object (File)
	Jul 21 2026, 6:46 AM

	Unknown Object (File)
	Jul 21 2026, 6:46 AM

Subscribers

Details

Reviewers

scottl
markj

Commits

rS320714: hptmv: avoid gcc variably-modified warning

Summary

gcc produces a "variably modified X at file scope" warning for structures that use these size definitions. I think the definitions are actually fine but can be rephrased with offsetof more cleanly anyway.

Looks like this was originally reported here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211540

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10209
Build 10630: arc lint + arc unit

Event Timeline

rlibby created this revision.Jun 29 2017, 9:39 PM

Harbormaster completed remote builds in B10209: Diff 30241.Jun 29 2017, 9:39 PM

rlibby added a subscriber: royger.Jun 29 2017, 9:45 PM

rlibby edited the summary of this revision. (Show Details)Jul 5 2017, 5:49 AM

rlibby added a subscriber: markmi_dsl-only.net.

Approved.

This revision is now accepted and ready to land.Jul 5 2017, 5:12 PM

Closed by commit rS320714: hptmv: avoid gcc variably-modified warning (authored by rlibby). · Explain WhyJul 6 2017, 5:32 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

hptmv/

vdevice.h

4 lines

Diff 30241

View Options

vdevice.h: avoid gcc variably-modified warningClosedPublicActions