I understand from the limited explanation in the review title, that this is a "return proper values" type of commit. The comments in the code and the way the code is structured seem to indicate that this code is trying to "workaround" something new or an existing bug. The way the code is implemented looks to bypass the existing detection and logic for media types in the code, as though there is something missing.

Can I get a better explanation on the failure case this code is trying to resolve? I don't know that it does what it is intended to do.

Yes, This is temporary workaround until our firmware team merges Link related features into main stream (ETA is 1 to 2 months).
For example, Current firmware is not filling interface_type which is required to derive Supported Speeds and workaround is to blindly support 10G, 25G, 50G & 100G when interface_type is 0.
I'm going to delete this workaround in future when our Firmware is ready with all Link related functionality.

Thanks,
Chenna.

Hi,

Can you please commit this patch if no further reviews?

Thanks,
Bhargava Chenna, Marreddy