Page MenuHomeFreeBSD

bnxt: Return proper values for 'supported media' & 'media' of ifconfig.
ClosedPublic

Authored by bhargava.marreddy_broadcom.com on May 19 2017, 1:45 PM.
Tags
None
Referenced Files
F103256889: D10816.diff
Fri, Nov 22, 5:21 PM
Unknown Object (File)
Sun, Nov 17, 5:52 PM
Unknown Object (File)
Mon, Nov 11, 4:44 AM
Unknown Object (File)
Sun, Nov 10, 12:17 AM
Unknown Object (File)
Thu, Oct 31, 11:01 PM
Unknown Object (File)
Sep 26 2024, 2:41 AM
Unknown Object (File)
Sep 25 2024, 2:57 PM
Unknown Object (File)
Sep 23 2024, 1:25 AM

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 9375
Build 9835: arc lint + arc unit

Event Timeline

I understand from the limited explanation in the review title, that this is a "return proper values" type of commit. The comments in the code and the way the code is structured seem to indicate that this code is trying to "workaround" something new or an existing bug. The way the code is implemented looks to bypass the existing detection and logic for media types in the code, as though there is something missing.

Can I get a better explanation on the failure case this code is trying to resolve? I don't know that it does what it is intended to do.

Yes, This is temporary workaround until our firmware team merges Link related features into main stream (ETA is 1 to 2 months).
For example, Current firmware is not filling interface_type which is required to derive Supported Speeds and workaround is to blindly support 10G, 25G, 50G & 100G when interface_type is 0.
I'm going to delete this workaround in future when our Firmware is ready with all Link related functionality.

Thanks,
Chenna.

This revision is now accepted and ready to land.May 23 2017, 8:00 PM

Hi,

Can you please commit this patch if no further reviews?

Thanks,
Bhargava Chenna, Marreddy

This revision was automatically updated to reflect the committed changes.