Differential D10387

ICMP rate-limit enhancements
ClosedPublic
Actions

Authored by jtl on Apr 13 2017, 4:54 PM.

Details

Reviewers

glebius

Group Reviewers

network

Commits

rS319214: Enforce the limit on ICMP messages before doing work to formulate the

Summary

Enforce the limit on ICMP messages before doing work to formulate the
response.

Delete an unneeded rate limit for UDP under IPv6. Because ICMP6
messages have their own rate limit, it is unnecessary to apply a
second rate limit to UDP messages.

MFC after: 2 weeks
Sponsored by: Netflix

Test Plan

Ensure limits still work.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jtl created this revision.Apr 13 2017, 4:54 PM

Herald added subscribers: ae, imp. · View Herald TranscriptApr 13 2017, 4:54 PM

Harbormaster completed remote builds in B8718: Diff 27420.Apr 13 2017, 4:54 PM

jtl mentioned this in D10388: ICMP6 rate-limit enhancements.Apr 13 2017, 4:59 PM

jtl added a reviewer: network.Apr 13 2017, 5:32 PM

glebius accepted this revision as: glebius.Apr 20 2017, 4:19 PM

This revision is now accepted and ready to land.Apr 20 2017, 4:19 PM

Closed by commit rS319214: Enforce the limit on ICMP messages before doing work to formulate the (authored by jtl). · Explain WhyMay 30 2017, 2:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

netinet/

ip_icmp.c

12 lines

netinet6/

udp6_usrreq.c

4 lines

Diff 29013

View Options

head/sys/netinet/ip_icmp.c