Initial changes submitted by emaste, bug fixes added by smahadevan
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
You are referring to https://svnweb.freebsd.org/base?view=revision&revision=317967 right? Was the breaking error something like: "makefs: bread: lseek 48 (-4393751551952): Invalid argument"? My bug fixes in this diff should fix the previously breaking revision. Specifically, the problem had to do with incorrectly casting a void * field in the vnode struct as fsinfo_t. Instead, this diff adds the v_fsinfo field to the struct vnode.
Comment Actions
Specifically, the makefs tests pass with this fixed version of the previously-reverted change.
| usr.sbin/makefs/ffs/ufs_inode.h | ||
|---|---|---|
| 48 ↗ | (On Diff #28526) | Ought to be named i_devvp for consistency with NetBSD's version. |
Comment Actions
One more minor divergence from NetBSD noted inline. I suggest we go ahead with this change, and revisit the whitespace later on.
| usr.sbin/makefs/ffs/buf.h | ||
|---|---|---|
| 60 ↗ | (On Diff #28540) | Should call this b_fs to match NetBSD |
Comment Actions
What's this diff relative to? It looks like e.g ffs/buf.c does not correspond to what is currently SVN master.
Comment Actions
Ah you're right, I think I must have included a few extra commits in the diff, I'll fix this diff and make it relative to master.