ClosedPublic
Actions

Authored by adrian on Dec 26 2014, 6:14 PM.

Details

Reviewers

jfv
gnn

Group Reviewers

network

Summary

The RSS code currently lives in sys/netinet/ and supports both IPv4 and IPv6.
But as part of the general network stack integration, stuff outside of netinet/
(eg, netisr) will need some information about the RSS setup and CPU mapping
so it can make decisions about CPU / RSS bucket allocations for netisr, CPU
pinning, later on it'll query NUMA topology and setup netisr accordingly, etc.

So:

the stuff to do with RSS configuration now lives in sys/net/rss_config.[ch];
the sysctl space is still net.inet.netisr for now, but that may change before 11-RELEASE is cut;
sys/netinet/in_rss.[ch] has IPv4 specific code in it;
sys/netinet6/in6_rss.[ch] has IPv6 specific code in it;
the IPv6 RSS code now uses pointers instead of copying the src/dst IPv6 addresses around.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

adrian updated this revision to Diff 2874.Dec 26 2014, 6:14 PM

adrian retitled this revision from to Break out RSS init path into sys/net; inet4 code in sys/netinet/; inet6 code in sys/netinet6/.

adrian updated this object.

adrian edited the test plan for this revision. (Show Details)

adrian added a reviewer: network.

gnn added a reviewer: jfv.Dec 28 2014, 5:16 AM

I can't really review this in Phabricator. Is there any chance we could reduce some noise from that change, e.g., making the IPv6 faddr/laddr pointers doesn't really belong in here. If we can brea such stuff out, reviewing the rest is a lot easier.

sys/net/rss_config.c
32	This probably just wants to become $FreeBSD$
sys/net/rss_config.h
105	Aeh, while I can see the point, the function will not allow you to abstract the KPI/KBI away either this way (static inline ...). Just saying.
sys/netinet/in_pcbgroup.c
47	This is misordered
sys/netinet/ip_output.c
75	misordered
sys/netinet6/in6_pcbgroup.c
44	Outside #ifdef INET6