Differential D10874

vmxnet3 crash when LRO is enabled
ClosedPublic
Actions

Authored by avg on May 23 2017, 4:23 PM.

Tags

None

Referenced Files

	F168551736: D10874.id28772.diff
	Fri, Aug 28, 11:55 PM

	F168551350: D10874.id28718.diff
	Fri, Aug 28, 11:53 PM

	Unknown Object (File)
	Wed, Aug 26, 1:53 PM

	Unknown Object (File)
	Tue, Aug 25, 11:42 PM

	Unknown Object (File)
	Mon, Aug 24, 11:07 PM

	Unknown Object (File)
	Mon, Aug 24, 11:04 PM

	Unknown Object (File)
	Wed, Aug 5, 4:27 AM

	Unknown Object (File)
	Jul 20 2026, 9:25 PM

Subscribers

Details

Reviewers

bryanv
rstone

Commits

rS318867: fix vmxnet3 crash when LRO is enabled

Summary

The crash can occur when all of the following conditions are true:

a packet consists of multiple segements (requires LRO enabled)
there has been a failure to allocate an mbuf for the packet and the packet has to be dropped
a host (vmware) still owned at least one segment of the packet, so the driver had to wait for another interrupt to proceed to discarding the remaning segment(s)

The work was sponsored by Panzura who run into the problem.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9458
Build 9910: arc lint + arc unit

Event Timeline

avg created this revision.May 23 2017, 4:23 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 23 2017, 4:23 PM

Harbormaster completed remote builds in B9458: Diff 28718.May 23 2017, 4:23 PM

avg edited the summary of this revision. (Show Details)May 23 2017, 4:25 PM

avg added a subscriber: network.May 23 2017, 4:28 PM

@rstone this is based on the discussion that we had on the IRC and the suggestion you made.

rstone accepted this revision.May 24 2017, 7:23 PM

This revision is now accepted and ready to land.May 24 2017, 7:23 PM

Closed by commit rS318867: fix vmxnet3 crash when LRO is enabled (authored by avg). · Explain WhyMay 25 2017, 10:50 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

vmware/

vmxnet3/

14 lines

Diff 28718

sys/dev/vmware/vmxnet3/if_vmx.c

Loading...