Page MenuHomeFreeBSD

For arm targets, place ABI at the end of the target triple
ClosedPublic

Authored by dim on May 21 2017, 6:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 26, 5:43 PM
Unknown Object (File)
Wed, Dec 25, 5:17 PM
Unknown Object (File)
Fri, Dec 20, 11:29 PM
Unknown Object (File)
Fri, Dec 20, 8:15 PM
Unknown Object (File)
Fri, Dec 20, 4:10 PM
Unknown Object (File)
Thu, Dec 5, 12:50 PM
Unknown Object (File)
Tue, Dec 3, 8:11 AM
Unknown Object (File)
Nov 12 2024, 2:42 AM
Subscribers

Details

Summary

For some reason, we have been inserting the ABI specification into the
middle of the target triple, when building LLVM, like so:

armv6-gnueabi-freebsd12.0

This is the wrong way around. LLVM even auto-canonicalizes it to:

armv6--freebsd12.0-gnueabi

Let's do this the right way in llvm.build.mk instead. While here,
define a proper VENDOR macro which can be overridden easily.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9423
Build 9881: arc lint + arc unit

Event Timeline

This seems correct to me, although I'm not sure what unanticipated fallout there might be and perhaps others will comment.

This revision is now accepted and ready to land.May 22 2017, 3:52 AM
This revision was automatically updated to reflect the committed changes.