Page MenuHomeFreeBSD

In m_clrprotoflags() cleanup the entire mbuf chain.
ClosedPublic

Authored by glebius on Dec 22 2014, 3:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 11, 10:50 PM
Unknown Object (File)
Fri, Oct 2, 7:45 PM
Unknown Object (File)
Thu, Oct 1, 5:42 PM
Unknown Object (File)
Thu, Oct 1, 4:00 AM
Unknown Object (File)
Thu, Oct 1, 3:33 AM
Unknown Object (File)
Wed, Sep 30, 4:09 PM
Unknown Object (File)
Wed, Sep 30, 4:01 PM
Unknown Object (File)
Wed, Sep 30, 2:39 PM
Subscribers

Details

Summary

The function is designed to cleanup M_PROTO flags when mbufs cross
protocol and facility boundaries. However, now it cleans up only the
first mbuf, while intent clearly means all mbufs in a possible chain.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

glebius retitled this revision from to In m_clrprotoflags() cleanup the entire mbuf chain..
glebius updated this object.
glebius added a reviewer: network.
rpaulo added a reviewer: rpaulo.
rpaulo added a subscriber: rpaulo.

In the commit log, I wouldn't use the pronoun "the" but instead you could make it clear you're talking about m_clrprotoflags().

This revision is now accepted and ready to land.Dec 22 2014, 6:11 PM
gnn added a reviewer: gnn.
gnn added a subscriber: gnn.

Looks good to me.

adrian added a reviewer: adrian.
adrian added a subscriber: adrian.

Yup, looks good to me too.

glebius updated this revision to Diff 2827.

Closed by commit rS276136 (authored by @glebius).