Page MenuHomeFreeBSD

loader: zfs reader vdev_probe should check for minimum device size
ClosedPublic

Authored by tsoome on Apr 13 2017, 6:07 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 9, 8:12 PM
Unknown Object (File)
Tue, Dec 3, 12:51 PM
Unknown Object (File)
Mon, Dec 2, 7:05 PM
Unknown Object (File)
Nov 22 2024, 8:33 AM
Unknown Object (File)
Nov 22 2024, 8:33 AM
Unknown Object (File)
Nov 22 2024, 8:33 AM
Unknown Object (File)
Nov 22 2024, 8:13 AM
Unknown Object (File)
Oct 18 2024, 8:41 AM
Subscribers

Details

Summary

The smallest device we can have in the pool is 64MB, since we are trying to walk all four labels to find the most up to date uberblock, this limit will alsogive us good method to check if we even should attempt to probe.

Enforcing the check also will make sure we are not getting wrapped while calculating the label offset.

Also, after label check, we should verify if we actually got any UB or not.

Diff Detail

Event Timeline

tsoome retitled this revision from loader: zfs reader vdev_probe should check for minimum pool size The smallest pool we can have is 64MB, since we are trying to walk all four labels to find the most up to date uberblock, this limit will also give us good method to check if we... to loader: zfs reader vdev_probe should check for minimum pool size.Apr 13 2017, 6:11 AM
tsoome edited the summary of this revision. (Show Details)
tsoome retitled this revision from loader: zfs reader vdev_probe should check for minimum pool size to loader: zfs reader vdev_probe should check for minimum device size.Apr 13 2017, 10:10 PM
tsoome edited the summary of this revision. (Show Details)

Looks straightforward enough

This revision is now accepted and ready to land.Apr 18 2017, 3:19 PM
This revision was automatically updated to reflect the committed changes.