loader: zfs reader vdev_probe should check for minimum device size
ClosedPublic
Actions

Authored by tsoome on Apr 13 2017, 6:07 AM.

Details

Reviewers

allanjude
imp

Commits

rS317092: loader: zfs reader vdev_probe should check for minimum device size

Summary

The smallest device we can have in the pool is 64MB, since we are trying to walk all four labels to find the most up to date uberblock, this limit will alsogive us good method to check if we even should attempt to probe.

Enforcing the check also will make sure we are not getting wrapped while calculating the label offset.

Also, after label check, we should verify if we actually got any UB or not.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tsoome created this revision.Apr 13 2017, 6:07 AM

Herald added a subscriber: delphij. · View Herald TranscriptApr 13 2017, 6:07 AM

tsoome retitled this revision from loader: zfs reader vdev_probe should check for minimum pool size The smallest pool we can have is 64MB, since we are trying to walk all four labels to find the most up to date uberblock, this limit will also give us good method to check if we... to loader: zfs reader vdev_probe should check for minimum pool size.Apr 13 2017, 6:11 AM

tsoome edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B8710: Diff 27398.Apr 13 2017, 6:44 AM

tsoome retitled this revision from loader: zfs reader vdev_probe should check for minimum pool size to loader: zfs reader vdev_probe should check for minimum device size.Apr 13 2017, 10:10 PM

tsoome edited the summary of this revision. (Show Details)

Looks straightforward enough

This revision is now accepted and ready to land.Apr 18 2017, 3:19 PM

Closed by commit rS317092: loader: zfs reader vdev_probe should check for minimum device size (authored by tsoome). · Explain WhyApr 18 2017, 3:44 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

boot/

zfs/

zfsimpl.c

11 lines

Diff 27521

View Options

head/sys/boot/zfs/zfsimpl.c

loader: zfs reader vdev_probe should check for minimum device sizeClosedPublicActions