In read_neighbor_cache sub command of hccontrol, there is no information on address type. And bluetooth LE advertise contains extended inquiry and RSSI.
This diff exports these information for user land and make hccontrol recognize them.
Details
Details
Prepare bluetooth LE device and
%hccontrol le_set_scan_enable enable
% hccontrol read_neighbor_cache
and view result.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 8687 Build 9019: CI src build Jenkins Build 9018: arc lint + arc unit
Event Timeline
Comment Actions
can you please add boundary checks? thanks!
| sys/netgraph/bluetooth/hci/ng_hci_evnt.c | ||
|---|---|---|
| 435 | do we need to make sure that mbuf really has n->extinq_data bytes available? what if actual data size is less than header says? | |
| usr.sbin/bluetooth/hccontrol/node.c | ||
| 234 | do we need to check elemlen here as well? basically what if elemlen is longer than supplied length? | |
| 279 | i think this is off by one, i.e. sizeof() will return 4, but last index is 3. what do you think? | |
Comment Actions
please see my comments above. thanks!
| sys/netgraph/bluetooth/hci/ng_hci_evnt.c | ||
|---|---|---|
| 436 | NG_HCI_M_PULLUP() alerts on result being NULL already. also, i think, we still need to check if mbuf actually has enough data. | |
| 440 | same comment as above, i.e. NG_HCI_M_PULLUP() warns, and, please check length to make sure data are present | |
| sys/netgraph/bluetooth/hci/ng_hci_evnt.c | ||
|---|---|---|
| 436 | Ok. I'll simply use m_pullup instead. | |
Comment Actions
Use m_pullup instead of NG_HCI_M_PULLUP, if mbuf has enough space, m_pullup will return NULL.
Comment Actions
I'm going to nitpick the commit a tad...
| head/sys/netgraph/bluetooth/hci/ng_hci_evnt.c | ||
|---|---|---|
| 428 ↗ | (On Diff #27790) | Whitespace |
| 434–435 ↗ | (On Diff #27790) | Isn't this the same as n->extinq_size = MIN(length_data, NG_HCI_EXTINQ_MAX);? |
| 439 ↗ | (On Diff #27790) | Whitespace |
| 445 ↗ | (On Diff #27790) | Remove space after char, i.e., event = m_pullup(event, sizeof(char)); |
| 447 ↗ | (On Diff #27790) | Whitespace |
| head/sys/netgraph/bluetooth/hci/ng_hci_main.c | ||
| 100 ↗ | (On Diff #27790) | Whitespace |
| head/usr.sbin/bluetooth/hccontrol/node.c | ||
| 211 ↗ | (On Diff #27790) | Please don't redefine MIN/MAX -- it's available in sys/param.h. |
| 213 ↗ | (On Diff #27790) | The definition format is incorrect: static int
hci_dump_adv(uint8_t *data, int length)
{ |
| 219 ↗ | (On Diff #27790) | style(9): please add whitespace, e.g., while (length > 0) { |
| 224 ↗ | (On Diff #27790) | Whitespace |
| 230 ↗ | (On Diff #27790) | Whitespace |
| 232 ↗ | (On Diff #27790) | Whitespace |
| 238 ↗ | (On Diff #27790) | Whitespace |
| 245 ↗ | (On Diff #27790) | Whitespace |
| 290 ↗ | (On Diff #27790) |
|
| 306–307 ↗ | (On Diff #27790) | Wrap to a single line? |
| 308 ↗ | (On Diff #27790) | Why not add this to the previous fprintf? |