Page MenuHomeFreeBSD
Differential D10292

Add external toolchain ports for aarch64
ClosedPublic
Actions

Authored by kan on Apr 6 2017, 1:04 AM.
Tags
None
Referenced Files
F153285052: D10292.diff
Mon, Apr 20, 6:15 AM
F153252924: D10292.id27211.diff
Mon, Apr 20, 2:10 AM
Unknown Object (File)
Wed, Apr 15, 4:47 PM
Unknown Object (File)
Wed, Apr 15, 10:16 AM
Unknown Object (File)
Wed, Apr 15, 6:14 AM
Unknown Object (File)
Wed, Apr 15, 3:25 AM
Unknown Object (File)
Tue, Apr 7, 10:52 AM
Unknown Object (File)
Mon, Apr 6, 7:55 AM
View All Files
Subscribers
brooks

Details

Reviewers
emaste
bapt
andreast
andrew
brooks
Commits
rP437977: Add external toolchain ports for aarch64
Summary

This involves copying patch file from lang/gcc6
and minor plist tweaks.

Test Plan

Try to build world with CROSS_TOOLCHAIN=aarch65-gcc

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 8546
Build 8853: arc lint + arc unit

Event Timeline

kan created this revision.Apr 6 2017, 1:04 AM
Harbormaster completed remote builds in B8546: Diff 27124.Apr 6 2017, 1:04 AM
thompsa edited edge metadata.Apr 6 2017, 3:03 AM

I think you intended to add Andrew Turner instead of me.

kan edited reviewers, added: andrew; removed: thompsa.Apr 6 2017, 4:19 AM
kan added a comment.Apr 6 2017, 4:21 AM

Indeed, corrected.

emaste edited edge metadata.Apr 6 2017, 6:44 PM

I think this is fine, but would like @andrew to confirm.

andreast accepted this revision.Apr 6 2017, 7:09 PM

Looks good.

This revision is now accepted and ready to land.Apr 6 2017, 7:09 PM
andrew edited edge metadata.Apr 6 2017, 11:03 PM
In D10292#213150, @emaste wrote:

I think this is fine, but would like @andrew to confirm.

I guess it's correct but don't know the internals of gcc well enough.

emaste accepted this revision.Apr 7 2017, 11:56 PM

I accept, but this will require a ports committer to approve for commit.

brooks accepted this revision.Apr 8 2017, 12:14 AM
brooks added a subscriber: brooks.

Looks good to me subject to hooking it up to devel/Makefile as discussed on IRC.

kan updated this revision to Diff 27210.Apr 8 2017, 12:17 AM
kan edited edge metadata.

Add missing devel/Makefile bit

This revision now requires review to proceed.Apr 8 2017, 12:17 AM
kan updated this revision to Diff 27211.Apr 8 2017, 12:19 AM

Remove unrelated bits.

Harbormaster completed remote builds in B8594: Diff 27211.Apr 8 2017, 12:19 AM
brooks accepted this revision.Apr 8 2017, 12:21 AM

LGTM

This revision is now accepted and ready to land.Apr 8 2017, 12:21 AM
Closed by commit rP437977: Add external toolchain ports for aarch64 (authored by kan). · Explain WhyApr 8 2017, 12:30 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
devel/
8 lines
428 lines
7 lines
powerpc64-gcc/
13 lines
files/
234 lines

Diff 27124

View Options

devel/aarch64-gcc/

Loading...
View Options

devel/aarch64-gcc/Makefile

Loading...
View Options

devel/aarch64-gcc/pkg-plist

Loading...
View Options

devel/aarch64-xtoolchain-gcc/

Loading...
View Options

devel/aarch64-xtoolchain-gcc/Makefile

Loading...
View Options

devel/powerpc64-gcc/Makefile

Loading...
View Options

devel/powerpc64-gcc/files/patch-aarch64-support

Loading...