This patch implements synthetic keyboard driver for FreeBSD on Hyper-V Gen2. In Gen2 mode, the legacy keyboard does not work.
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Looks pretty good to me. Some minor code style suggestion.
| sys/dev/hyperv/input/hv_kbdc.c | ||
|---|---|---|
| 107–118 ↗ | (On Diff #26810) | May be we should use more consistent style of comment? /* * */ or your preference: /** * */ |
| 307 ↗ | (On Diff #26810) | I'd prefer for (;;) |
| 331–342 ↗ | (On Diff #26810) | We don't indent switch-case: switch () {
case XXX:
aaaa;
case YYY:
bbbb;
default:
cccc;
} |
| 67–69 ↗ | (On Diff #26807) | Better use C style comment, or '#if 0 ... #endif' |