Page MenuHomeFreeBSD

implement initial Hyperv keyboard synthetic driver
ClosedPublic

Authored by honzhan_microsoft.com on Mar 30 2017, 5:59 AM.
Tags
None
Referenced Files
F165767139: D10196.id26807.diff
Sun, Aug 9, 5:49 PM
F165618299: D10196.id26810.diff
Sat, Aug 8, 7:56 PM
F165615561: D10196.id27079.diff
Sat, Aug 8, 7:47 PM
Unknown Object (File)
Sat, Aug 8, 2:51 PM
Unknown Object (File)
Fri, Aug 7, 12:49 AM
Unknown Object (File)
Thu, Aug 6, 6:38 PM
Unknown Object (File)
Thu, Aug 6, 1:34 PM
Unknown Object (File)
Thu, Aug 6, 8:55 AM
Subscribers
None

Details

Summary

This patch implements synthetic keyboard driver for FreeBSD on Hyper-V Gen2. In Gen2 mode, the legacy keyboard does not work.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Looks pretty good to me. Some minor code style suggestion.

sys/dev/hyperv/input/hv_kbdc.c
68–70

Better use C style comment, or '#if 0 ... #endif'

108–119

May be we should use more consistent style of comment?

/*
 *
 */

or your preference:

/**
 *
 */
308

I'd prefer for (;;)

332–343

We don't indent switch-case:

switch () {
case XXX:
    aaaa;
case YYY:
    bbbb;
default:
    cccc;
}
This revision is now accepted and ready to land.Mar 30 2017, 7:54 AM
This revision now requires review to proceed.Mar 30 2017, 8:08 AM
This revision was automatically updated to reflect the committed changes.