Page MenuHomeFreeBSD

implement initial Hyperv keyboard synthetic driver
ClosedPublic

Authored by honzhan_microsoft.com on Mar 30 2017, 5:59 AM.
Tags
None
Referenced Files
F117262634: D10196.diff
Thu, May 15, 11:44 PM
Unknown Object (File)
Tue, May 13, 6:09 PM
Unknown Object (File)
Sun, May 4, 5:49 PM
Unknown Object (File)
Fri, Apr 18, 11:59 AM
Unknown Object (File)
Mar 19 2025, 3:43 PM
Unknown Object (File)
Mar 15 2025, 7:09 AM
Unknown Object (File)
Mar 9 2025, 11:59 PM
Unknown Object (File)
Feb 28 2025, 4:07 PM
Subscribers
None

Details

Summary

This patch implements synthetic keyboard driver for FreeBSD on Hyper-V Gen2. In Gen2 mode, the legacy keyboard does not work.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Looks pretty good to me. Some minor code style suggestion.

sys/dev/hyperv/input/hv_kbdc.c
68–70

Better use C style comment, or '#if 0 ... #endif'

108–119

May be we should use more consistent style of comment?

/*
 *
 */

or your preference:

/**
 *
 */
308

I'd prefer for (;;)

332–343

We don't indent switch-case:

switch () {
case XXX:
    aaaa;
case YYY:
    bbbb;
default:
    cccc;
}
This revision is now accepted and ready to land.Mar 30 2017, 7:54 AM
This revision now requires review to proceed.Mar 30 2017, 8:08 AM
This revision was automatically updated to reflect the committed changes.