Page MenuHomeFreeBSD

implement initial Hyperv keyboard synthetic driver
ClosedPublic

Authored by honzhan_microsoft.com on Mar 30 2017, 5:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 10 2024, 9:02 AM
Unknown Object (File)
Dec 22 2023, 11:53 PM
Unknown Object (File)
Dec 16 2023, 1:02 AM
Unknown Object (File)
Dec 15 2023, 1:23 AM
Unknown Object (File)
Dec 12 2023, 9:41 PM
Unknown Object (File)
Oct 31 2023, 11:21 AM
Unknown Object (File)
Oct 9 2023, 12:30 AM
Unknown Object (File)
Sep 25 2023, 9:15 AM
Subscribers
None

Details

Summary

This patch implements synthetic keyboard driver for FreeBSD on Hyper-V Gen2. In Gen2 mode, the legacy keyboard does not work.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Looks pretty good to me. Some minor code style suggestion.

sys/dev/hyperv/input/hv_kbdc.c
68–70

Better use C style comment, or '#if 0 ... #endif'

107–118

May be we should use more consistent style of comment?

/*
 *
 */

or your preference:

/**
 *
 */
307

I'd prefer for (;;)

331–342

We don't indent switch-case:

switch () {
case XXX:
    aaaa;
case YYY:
    bbbb;
default:
    cccc;
}
This revision is now accepted and ready to land.Mar 30 2017, 7:54 AM
This revision now requires review to proceed.Mar 30 2017, 8:08 AM
This revision was automatically updated to reflect the committed changes.