Correct a kernel stack leak in 32-bit compat when vfc_name is short.
ClosedPublic
Actions

Authored by brooks on Mar 31 2017, 9:30 PM.

Details

Reviewers

rwatson
glebius
delphij

Group Reviewers

secteam

Commits

rS316497: Correct a kernel stack leak in 32-bit compat when vfc_name is short.

Summary

Don't zero unused pointer members again.

Per discussion with secteam we are not issuing an advisory for this
issue as we have no current evidence it leaks exploitable information.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.Mar 31 2017, 9:30 PM

Harbormaster completed remote builds in B8427: Diff 26896.Mar 31 2017, 9:30 PM

brooks added a reviewer: secteam.Mar 31 2017, 9:31 PM

Seems sensible.

This revision is now accepted and ready to land.Mar 31 2017, 9:37 PM

glebius accepted this revision.Apr 4 2017, 2:27 PM

delphij accepted this revision.Apr 4 2017, 5:05 PM

Closed by commit rS316497: Correct a kernel stack leak in 32-bit compat when vfc_name is short. (authored by brooks). · Explain WhyApr 4 2017, 5:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

vfs_subr.c

3 lines

Diff 27045

View Options

head/sys/kern/vfs_subr.c

Property	Old Value	New Value
svn:eol-style	null	native \ No newline at end of property
svn:keywords	null	FreeBSD=%H \ No newline at end of property
svn:mime-type	null	text/plain \ No newline at end of property

				# $FreeBSD$

				PORTNAME= pyfda
				PORTVERSION= 0.1
				DISTVERSIONSUFFIX= rc6
				CATEGORIES= cad python devel
				MASTER_SITES= CHEESESHOP
				PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX}

				MAINTAINER= yuri@FreeBSD.org
				COMMENT= GUI tool for designing and analysing discrete time filters

				LICENSE= MIT
				LICENSE_FILE= ${WRKSRC}/LICENSE

				RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}docutils>0:textproc/py-docutils@${FLAVOR} \
				${PYTHON_PKGNAMEPREFIX}matplotlib>0:math/py-matplotlib@${FLAVOR} \
				${PYNUMPY} \
				${PYTHON_PKGNAMEPREFIX}scipy>0:science/py-scipy@${FLAVOR}

				USES= python:3.4+ pyqt:5
				USE_PYTHON= distutils autoplist noflavors
				matUnsubmitted Not Done Inline Actions Also, setting noflavors (which is weird, no reason to do it) means that the FLAVOR variable is empty, thus, it makes this port broken because the dependencies line end with @ with no flavor. mat: Also, setting noflavors (which is weird, no reason to do it) means that the FLAVOR variable is…
				yuriAuthorUnsubmitted Not Done Inline Actions But this is an app, not a library. Shouldn't python apps all be `noflavors`? yuri: But this is an app, not a library. Shouldn't python apps all be `noflavors`?
				matUnsubmitted Not Done Inline Actions this has a PKGNAMEPREFIX, nothing against it having noflavors. mat: this has a PKGNAMEPREFIX, nothing against it having noflavors.
				USE_PYQT= core_run gui_run widgets_run
				NO_ARCH= yes

				post-extract:
				@${MV} ${WRKSRC}/pyfda/pyfda_log.conf ${WRKSRC}/pyfda/pyfda_log.conf.sample
				@${MV} ${WRKSRC}/pyfda/pyfda_log_debug.conf ${WRKSRC}/pyfda/pyfda_log_debug.conf.sample

				post-patch:
				@${REINPLACE_CMD} -e " \
				s\|package_data={'pyfda': \['pyfda_log.conf', 'pyfda_log_debug.conf',\|package_data={'pyfda': [\|; \
				s\|data_files = \[\|data_files = [('${PREFIX}/etc', ['pyfda/pyfda_log.conf.sample', 'pyfda/pyfda_log_debug.conf.sample'])\|" \
				${WRKSRC}/setup.py
				@${REINPLACE_CMD} -e " \
				s\|logging.config.fileConfig(os.path.join(base_dir, rc.log_config_file))\|logging.config.fileConfig(os.path.join('${PREFIX}/etc', rc.log_config_file))\|" \
				${WRKSRC}/pyfda/pyfdax.py
				@${REINPLACE_CMD} -e " \
				s\|'pyfda.log'\|'/tmp/pyfda.log'\|" \
				${WRKSRC}/pyfda/*.conf.sample

				post-stage:
				@${REINPLACE_CMD} -E " \
				s\|(.*\.sample)$$\|@sample \1\|" \
				${WRKDIR}/.PLIST.pymodtmp

				.include <bsd.port.mk>

Correct a kernel stack leak in 32-bit compat when vfc_name is short.ClosedPublicActions