Differential D10140

diff: Fix mtime of file1 in -u/-c header line.
ClosedPublic
Actions

Authored by jilles on Mar 25 2017, 10:10 PM.

Details

Reviewers

bapt

Commits

rS315985: diff: Fix mtime of file1 in -u/-c header line.

Summary

Calling localtime() a second time overwrites the result of the first call.
Use localtime_r() instead.

PR: 218018

Test Plan

A new test case is included.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	usr.bin/diff/tests/diff_test.sh:	CHMOD1	Invalid Executable

Unit

No Test Coverage

Build Status

Buildable 8292
Build 8541: CI src build	Jenkins
Build 8540: arc lint + arc unit

Event Timeline

jilles created this revision.Mar 25 2017, 10:10 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 25 2017, 10:10 PM

Harbormaster failed remote builds in B8292: Diff 26660!Mar 25 2017, 10:10 PM

Fixing the nanoseconds (also PR 218018) will be a separate diff.

bapt accepted this revision.Mar 25 2017, 11:48 PM

This revision is now accepted and ready to land.Mar 25 2017, 11:48 PM

Closed by commit rS315985: diff: Fix mtime of file1 in -u/-c header line. (authored by jilles). · Explain WhyMar 26 2017, 2:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

usr.bin/

diff/

diffreg.c

6 lines

tests/

Makefile

3 lines

diff_test.sh

13 lines

header.out

4 lines

Diff 26660

View Options

usr.bin/diff/diffreg.c

View Options

usr.bin/diff/tests/Makefile

View Options

usr.bin/diff/tests/diff_test.sh

View Options

usr.bin/diff/tests/header.out

diff: Fix mtime of file1 in -u/-c header line.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 26660

usr.bin/diff/diffreg.c

usr.bin/diff/tests/Makefile

usr.bin/diff/tests/diff_test.sh

usr.bin/diff/tests/header.out

diff: Fix mtime of file1 in -u/-c header line.
ClosedPublic
Actions

Revision Contents
Changeset List