Page MenuHomeFreeBSD
Differential D10140

diff: Fix mtime of file1 in -u/-c header line.
ClosedPublic
Actions

Authored by jilles on Mar 25 2017, 10:10 PM.
Tags
None
Referenced Files
F124997192: D10140.diff
Sat, Aug 2, 5:05 AM
Unknown Object (File)
Tue, Jul 22, 5:48 AM
Unknown Object (File)
Fri, Jul 4, 5:55 PM
Unknown Object (File)
Fri, Jul 4, 2:07 AM
Unknown Object (File)
Jun 17 2025, 11:22 PM
Unknown Object (File)
Jun 15 2025, 12:58 PM
Unknown Object (File)
Jun 11 2025, 7:55 AM
Unknown Object (File)
Jun 5 2025, 5:45 PM
View All 56 Files
Subscribers
imp

Details

Reviewers
bapt
Commits
rS315985: diff: Fix mtime of file1 in -u/-c header line.
Summary

Calling localtime() a second time overwrites the result of the first call.
Use localtime_r() instead.

PR: 218018

Test Plan

A new test case is included.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jilles created this revision.Mar 25 2017, 10:10 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 25 2017, 10:10 PM
Harbormaster failed remote builds in B8292: Diff 26660!Mar 25 2017, 10:10 PM
jilles added a comment.Mar 25 2017, 10:20 PM

Fixing the nanoseconds (also PR 218018) will be a separate diff.

bapt accepted this revision.Mar 25 2017, 11:48 PM
This revision is now accepted and ready to land.Mar 25 2017, 11:48 PM
Closed by commit rS315985: diff: Fix mtime of file1 in -u/-c header line. (authored by jilles). · Explain WhyMar 26 2017, 2:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
usr.bin/
diff/
6 lines
tests/
3 lines
13 lines
4 lines

Diff 26670

View Options

head/usr.bin/diff/diffreg.c

Loading...
View Options

head/usr.bin/diff/tests/Makefile

Loading...
View Options

head/usr.bin/diff/tests/diff_test.sh

Loading...
View Options

head/usr.bin/diff/tests/header.out

Loading...