Page MenuHomeFreeBSD
Differential D10140

diff: Fix mtime of file1 in -u/-c header line.
ClosedPublic
Actions

Authored by jilles on Mar 25 2017, 10:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 28, 8:06 AM
Unknown Object (File)
Sun, Oct 26, 9:46 AM
Unknown Object (File)
Sun, Oct 26, 9:46 AM
Unknown Object (File)
Sun, Oct 26, 9:46 AM
Unknown Object (File)
Sun, Oct 26, 3:09 AM
Unknown Object (File)
Fri, Oct 24, 7:16 AM
Unknown Object (File)
Sun, Oct 5, 7:01 AM
Unknown Object (File)
Oct 4 2025, 6:08 AM
View All 67 Files
Subscribers
imp

Details

Reviewers
bapt
Commits
rS315985: diff: Fix mtime of file1 in -u/-c header line.
Summary

Calling localtime() a second time overwrites the result of the first call.
Use localtime_r() instead.

PR: 218018

Test Plan

A new test case is included.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningusr.bin/diff/tests/diff_test.sh:CHMOD1Invalid Executable
Unit
No Test Coverage
Build Status
Buildable 8292
Build 8541: CI src buildJenkins
Build 8540: arc lint + arc unit

Event Timeline

jilles created this revision.Mar 25 2017, 10:10 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 25 2017, 10:10 PM
Harbormaster failed remote builds in B8292: Diff 26660!Mar 25 2017, 10:10 PM
jilles added a comment.Mar 25 2017, 10:20 PM

Fixing the nanoseconds (also PR 218018) will be a separate diff.

bapt accepted this revision.Mar 25 2017, 11:48 PM
This revision is now accepted and ready to land.Mar 25 2017, 11:48 PM
Closed by commit rS315985: diff: Fix mtime of file1 in -u/-c header line. (authored by jilles). · Explain WhyMar 26 2017, 2:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
usr.bin/
diff/
6 lines
tests/
3 lines
13 lines
4 lines

Diff 26660

View Options

usr.bin/diff/diffreg.c

Loading...
View Options

usr.bin/diff/tests/Makefile

Loading...
View Options

usr.bin/diff/tests/diff_test.sh

Loading...
View Options

usr.bin/diff/tests/header.out

Loading...