Reduce ARC fragmentaion threshold
ClosedPublic
Actions

Authored by smh on Mar 15 2017, 12:40 PM.

Details

Reviewers

mav
avg

Commits

rS315449: Reduce ARC fragmentation threshold

Summary

As ZFS can request up to SPA_MAXBLOCKSIZE memory block e.g. during zfs recv, update the threshold at which we start agressive reclamation to use SPA_MAXBLOCKSIZE (16M) instead of the lower zfs_max_recordsize which defaults to 1M.

This was reported here:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=194513

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

smh created this revision.Mar 15 2017, 12:40 PM

Herald added subscribers: delphij, imp. · View Herald TranscriptMar 15 2017, 12:40 PM

smh added a reviewer: mav.Mar 15 2017, 12:40 PM

I have no objections. It may be too aggressive if fragmentation was somehow caused not by ZFS, but any way I don't know any other place in system which would bother to do this, while I know other places that suffer quietly from fragmentation.

This revision is now accepted and ready to land.Mar 15 2017, 12:45 PM

Harbormaster completed remote builds in B8058: Diff 26273.Mar 15 2017, 1:15 PM

smh added a reviewer: avg.Mar 17 2017, 12:14 PM

avg accepted this revision.Mar 17 2017, 12:22 PM

Closed by commit rS315449: Reduce ARC fragmentation threshold (authored by smh). · Explain WhyMar 17 2017, 12:35 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

cddl/

contrib/

opensolaris/

uts/

common/

fs/

zfs/

arc.c

2 lines

Diff 26349

View Options

head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/arc.c

	Show First 20 Lines • Show All 276 Lines • ▼ Show 20 Lines
	__DEFAULT_DEPENDENT_OPTIONS+= LLVM_TARGET_${__llt:${__LLVM_TARGET_FILT}:tu}/LLVM_TARGET_ALL			__DEFAULT_DEPENDENT_OPTIONS+= LLVM_TARGET_${__llt:${__LLVM_TARGET_FILT}:tu}/LLVM_TARGET_ALL
	.endif			.endif
	.endfor			.endfor

	__DEFAULT_NO_OPTIONS+=LLVM_TARGET_BPF LLVM_TARGET_MIPS			__DEFAULT_NO_OPTIONS+=LLVM_TARGET_BPF LLVM_TARGET_MIPS

	.include <bsd.compiler.mk>			.include <bsd.compiler.mk>

	.if ${__T} == "aarch64" \|\| ${__T} == "amd64" \|\| ${__T} == "i386"			.if ${__T} == "aarch64" \|\| ${__T} == "amd64" \|\| ${__T} == "i386" \|\| ${__T:Mpowerpc*}
				impUnsubmitted Not Done Inline Actions so only armv and riscv are broken? Maybe it's time to reverse the sense of this conditional? imp: so only armv and riscv are broken? Maybe it's time to reverse the sense of this conditional?
				emasteUnsubmitted Not Done Inline Actions I suspect that 32-bit arm is fine, so it could probably be just != riscv. In any case though I think we can do it as a separate change. emaste: I suspect that 32-bit arm is fine, so it could probably be just != riscv. In any case though I…
	__DEFAULT_YES_OPTIONS+=LLDB			__DEFAULT_YES_OPTIONS+=LLDB
	.else			.else
	__DEFAULT_NO_OPTIONS+=LLDB			__DEFAULT_NO_OPTIONS+=LLDB
	.endif			.endif
	# LIB32 is supported on amd64 and powerpc64			# LIB32 is supported on amd64 and powerpc64
	.if (${__T} == "amd64" \|\| ${__T} == "powerpc64")			.if (${__T} == "amd64" \|\| ${__T} == "powerpc64")
	__DEFAULT_YES_OPTIONS+=LIB32			__DEFAULT_YES_OPTIONS+=LIB32
	.else			.else
	▲ Show 20 Lines • Show All 206 Lines • Show Last 20 Lines

Reduce ARC fragmentaion thresholdClosedPublicActions